chore: self-maintain Node.js features - #467
Open
avivkeller wants to merge 5 commits into
Open
avivkeller wants to merge 5 commits into
avivkeller wants to merge 5 commits into
Conversation
avivkeller
force-pushed
the
nodejs-self-maintain
branch
from
September 20, 2026 19:45
4e13bd9 to
20f14bb
Compare
avivkeller
marked this pull request as ready for review
September 20, 2026 19:45
Member
Author
Member
|
I like this approach, but I'm not sure we can remove the vendored source code from this repository. |
Member
Author
Can you elaborate on why not? It's still a dependency, but no longer one that's embedded in this repo's source, since it's a regular crate dep |
Member
|
@marco-ippolito Can we remove the vendoring of the SWC source code? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative solution to swc-project/swc#12395 (fixes swc-project/swc#12378). The majority of this PR is the removal of swc as a vendored dependency, and instead it's updating will be handled by Dependabot (since this package no longer needs to be compiled to WASM on update, it's now just a regular dependency).
This also reduces Amaro's built size by ~1MB.
This PR makes Amaro a rust crate that depends on SWC, rather than a wrapper around a custom SWC crate. The changes were were heavily inspired from and pieces were taken from SWC, so let me know how I should Co-Author y'all.
Note: Commit 3d891b8 only removes files.