Skip to content

Release v4.0.0 (4/4): desktop shells and all-platform CI - #73

Merged
nixrajput merged 10 commits into
feat/v4-examplefrom
feat/v4-desktop
Sep 29, 2026
Merged

nixrajput merged 10 commits into
feat/v4-examplefrom
feat/v4-desktop

Conversation

@nixrajput

@nixrajput nixrajput commented Sep 28, 2026 •

Copy link
Copy Markdown
Owner

Stacked PR 4 of 4. Targets feat/v4-example (#72), so this diff shows only the desktop shells and the example workflow. As part of the stack, master's CI runs here too.
Merging: this is the top of GitHub stack #74. Merging it with squash lands all four PRs together, one squashed commit each, and the release runs once on the finished tree. master requires an approval of the latest push and a stack cannot use the admin bypass, so either relax that rule for the merge or fold the layers down first.

Summary

  • Desktop: macOS, Windows and Linux regenerated with flutter create --org com.nixrajput on Flutter 3.47.5, with app icons from the logo (macOS on Apple's 824/1024 grid). This replaces the 3.x Windows shell and adds macOS and Linux.
  • example.yml: builds the example for Android, iOS, macOS, Windows, Linux, web and Wasm on every pull request, so a template or API change that breaks one of them shows here.

Type of change

  • Bug fix
  • New feature
  • Refactor / code cleanup
  • Documentation
  • CI / tooling
  • Dependency update

Related issues

Part of the 4.0.0 release in #70.

How to test

  1. cd example && flutter build macos --debug (Windows and Linux build in example.yml).

Verification checklist

Run locally on this branch, in a clean worktree, with this branch's CI steps:

  • dart format --output=none --set-exit-if-changed . - clean
  • flutter analyze - 0 issues
  • flutter test - all tests pass (202)
  • (cd example && flutter test) - layout tests pass (14)
  • Flutter 3.47.0 floor: analyze clean, 202 tests pass
  • macOS debug build succeeds; Windows and Linux are left to example.yml, which cannot run them on this Mac
  • This branch's tree equals the finished feat/v4
  • No unrelated changes included in this PR

🤖 Generated with Claude Code

- macOS, Windows and Linux recreated under com.nixrajput on Flutter
  3.47.5, with app icons from the logo.
- example.yml builds the example for all six platforms, web as both
  JS and Wasm, on every pull request.
@nixrajput nixrajput self-assigned this Sep 28, 2026
@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: nixrajput/flutter_carousel_widget/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 48b4c43a-2ce2-4fe3-87fc-1d8e7ccc6c5e

📥 Commits

Reviewing files that changed from the base of the PR and between da94f08 and 871cc35.

⛔ Files ignored due to path filters (9)
  • example/macos/Runner.xcworkspace/contents.xcworkspacedata is excluded by !**/*.xcworkspace/contents.xcworkspacedata
  • example/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_1024.png is excluded by !**/*.png, !example/**/*.png
  • example/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_128.png is excluded by !**/*.png, !example/**/*.png
  • example/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_16.png is excluded by !**/*.png, !example/**/*.png
  • example/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_256.png is excluded by !**/*.png, !example/**/*.png
  • example/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_32.png is excluded by !**/*.png, !example/**/*.png
  • example/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_512.png is excluded by !**/*.png, !example/**/*.png
  • example/macos/Runner/Assets.xcassets/AppIcon.appiconset/app_icon_64.png is excluded by !**/*.png, !example/**/*.png
  • example/windows/runner/resources/app_icon.ico is excluded by !**/*.ico, !example/**/*.ico
📒 Files selected for processing (46)
  • .github/workflows/example.yml
  • example/.metadata
  • example/linux/.gitignore
  • example/linux/CMakeLists.txt
  • example/linux/flutter/CMakeLists.txt
  • example/linux/flutter/generated_plugin_registrant.cc
  • example/linux/flutter/generated_plugin_registrant.h
  • example/linux/flutter/generated_plugins.cmake
  • example/linux/runner/CMakeLists.txt
  • example/linux/runner/main.cc
  • example/linux/runner/my_application.cc
  • example/linux/runner/my_application.h
  • example/macos/.gitignore
  • example/macos/Flutter/Flutter-Debug.xcconfig
  • example/macos/Flutter/Flutter-Release.xcconfig
  • example/macos/Flutter/GeneratedPluginRegistrant.swift
  • example/macos/Runner.xcodeproj/project.pbxproj
  • example/macos/Runner.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist
  • example/macos/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme
  • example/macos/Runner.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist
  • example/macos/Runner/AppDelegate.swift
  • example/macos/Runner/Assets.xcassets/AppIcon.appiconset/Contents.json
  • example/macos/Runner/Base.lproj/MainMenu.xib
  • example/macos/Runner/Configs/AppInfo.xcconfig
  • example/macos/Runner/Configs/Debug.xcconfig
  • example/macos/Runner/Configs/Release.xcconfig
  • example/macos/Runner/Configs/Warnings.xcconfig
  • example/macos/Runner/DebugProfile.entitlements
  • example/macos/Runner/Info.plist
  • example/macos/Runner/MainFlutterWindow.swift
  • example/macos/Runner/Release.entitlements
  • example/macos/RunnerTests/RunnerTests.swift
  • example/windows/.gitignore
  • example/windows/CMakeLists.txt
  • example/windows/flutter/CMakeLists.txt
  • example/windows/runner/CMakeLists.txt
  • example/windows/runner/Runner.rc
  • example/windows/runner/flutter_window.cpp
  • example/windows/runner/flutter_window.h
  • example/windows/runner/main.cpp
  • example/windows/runner/resource.h
  • example/windows/runner/runner.exe.manifest
  • example/windows/runner/utils.cpp
  • example/windows/runner/utils.h
  • example/windows/runner/win32_window.cpp
  • example/windows/runner/win32_window.h

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nixrajput

Copy link
Copy Markdown
Owner Author

CodeRabbit's PR review limit refused the auto reviews on this layer, so it was reviewed with the CodeRabbit CLI instead (coderabbit review --agent --committed --base-commit 5c3ff65, the tip of #72, so the diff is this layer's own files at 561a232).

Result: 1 finding, declined.

  • Trivial, example/windows/runner/win32_window.h line 67: the comment above OnCreate says CreateAndShow where the method is now Create. That's true, but the file is byte-identical to what flutter create --platforms windows generates on Flutter 3.47.5, so the stale comment is upstream's. Editing it here would make the runner diverge from the template it is regenerated from, and the fix belongs in the Flutter template.

@nixrajput
nixrajput merged commit 7bca33a into master Sep 29, 2026
13 checks passed
@nixrajput
nixrajput deleted the feat/v4-desktop branch September 29, 2026 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant