Skip to content

various dope updates#32

Open
noahehall wants to merge 2 commits into
nitin42:masterfrom
noahehall:master
Open

various dope updates#32
noahehall wants to merge 2 commits into
nitin42:masterfrom
noahehall:master

Conversation

@noahehall

@noahehall noahehall commented Apr 23, 2018

Copy link
Copy Markdown

will update with changes soon as possible

@nitin42

nitin42 commented Apr 25, 2018

Copy link
Copy Markdown
Owner

This PR seems great. Thank you so much for your work. I'll review it fully this weekend!

@noahehall

noahehall commented Apr 26, 2018

Copy link
Copy Markdown
Author

Hi @nitin42

Please dont critically review just yet! posted just to make sure your aware this is coming down the pipeline.

I still need to:

  • squash the commits
  • update the failing tests
  • finish adding all of the new react 16 phases
  • remove the interval that checks for new performance measures and use a custom event as described here

as a side note - I did a demo of this awesome module for some colleagues and we all felt that presenting the data in a table would increase our ability to analyze and interpret the results.

Thus this PR will also add an ability to to switch between the pie/donut charts to a table.

@nitin42

nitin42 commented Apr 27, 2018

Copy link
Copy Markdown
Owner

That's awesome!

@nitin42

nitin42 commented Jul 4, 2018

Copy link
Copy Markdown
Owner

Hey, just wanted to check-in! Any updates on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants