Repository navigation
Adding Improve DC Noise Rejection example in NI-DMM - #2217
divakar-selvam07 wants to merge 11 commits into
Conversation
…into users/diva/add-nidmm-improve-dc-noise-rejection-example
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2217 +/- ##
=======================================
Coverage 88.11% 88.12%
=======================================
Files 88 88
Lines 22832 22832
=======================================
+ Hits 20119 20120 +1
+ Misses 2713 2712 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…dmm-improve-dc-noise-rejection-example # Conflicts: # docs/nidmm/examples.rst
|
This PR is ready for @Avinash2Suresh 's review. |
|
@jarnoldNI , the PR is ready for your review. |
| parser.add_argument('--auto-zero', default='OFF', choices=nidmm.AutoZero.__members__.keys(), type=str.upper, help='Specifies the AutoZero mode.') | ||
| parser.add_argument('-a', '--aperture-time', default=0.1, type=float, help='Specifies the measurement aperture time for the current configuration, in seconds.') | ||
| parser.add_argument('--dc-noise-rejection', default='NORMAL', choices=supported_noise_rejection_modes, type=str.upper, help='Specifies the DC noise rejection mode.') | ||
| parser.add_argument('-s', '--sample-count', default=10, type=int, help='Specifies the number of measurements the DMM takes each time it receives a trigger in a multiple point acquisition.') |
There was a problem hiding this comment.
Can you also add the number of averages property for the user to set? I know this isn't in the DC noise rejection example but I think it's a useful thing to show. You can set the default to 8 (which is what is set in the LV example called "Improve DC Resolution").
After adding it, can you add a comment (place comment above in example) explaining the number of averages. Something like "For measurements with a long aperture time (>100ms), it is recommend that Auto Zero is enabled. To compensate for any drift during the aperture time, several shorter measurements can be taken with a new Auto Zero offset applied to each measurement. These measurement are then averaged and a single value is returned."
5 participants
I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
nidmm_improve_dc_noise_rejection.py, a Python adaptation of the LabVIEW “Improve DC Noise Rejection” example.List issues fixed by this Pull Request below, if any.
None
What testing has been done?