fix: preserve overview updates during concurrent config applies - #1938
Open
pooyanazad wants to merge 1 commit into
Open
pooyanazad wants to merge 1 commit into
pooyanazad wants to merge 1 commit into
Conversation
Contributor
|
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
Author
|
I have hereby read the F5 CLA and agree to its terms |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1938 +/- ##
==========================================
+ Coverage 88.94% 88.97% +0.02%
==========================================
Files 111 111
Lines 12413 12422 +9
==========================================
+ Hits 11041 11052 +11
+ Misses 1370 1368 -2
Partials 2 2
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
pooyanazad
force-pushed
the
fix/1927-buffer-nginx-config-context
branch
from
September 18, 2026 12:40
8b71fa9 to
d184b42
Compare
Config context updates were dropped whenever another apply was in progress. Keep the latest context per instance and publish it when watchers are re-enabled, as long as it still matches the completed apply. Add coverage for matching and stale buffered contexts. Fixes nginx#1927
pooyanazad
force-pushed
the
fix/1927-buffer-nginx-config-context
branch
from
September 18, 2026 12:41
d184b42 to
f6e5182
Compare
Author
|
Fixed the lint issues from the previous CI run and squashed the fixes into the original commit. Ready for another CI run and review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config context updates were dropped whenever another apply was in progress. Keep the latest context per instance and publish it when watchers are re-enabled, as long as it still matches the completed apply.
Add coverage for matching and stale buffered contexts.
Fixes #1927
Proposed changes
When two identical config applies overlap, the watcher can discard the
configuration context from the first apply. The second apply then sees the
same cached context, so neither apply publishes
NginxConfigUpdateTopicandUpdateOverviewis never sent.This change buffers the latest configuration context for each instance while
a config apply is in progress. When watchers are re-enabled, the buffered
context is published only if it matches the completed apply context. Stale
contexts are discarded.
Testing
go test -count=1 ./internal/watcher/...go test -race -count=1 ./internal/watcherChecklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull request