fix: ignore proxy_protocol listen sockets during api discovery (#978) - #1910
Open
devaniketh wants to merge 1 commit into
Open
devaniketh wants to merge 1 commit into
devaniketh wants to merge 1 commit into
Conversation
Contributor
|
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
Author
|
I have hereby read the F5 CLA and agree to its terms |
Author
|
recheck |
Author
|
@aknot242 hey kindly check the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
When NGINX is configured with
listen ... proxy_protocol;, connecting to that socket requires an immediate PROXY protocol header. The agent's config parser previously created plain HTTP endpoint URLs for these sockets, causing NGINX connection resets (broken header: "GET /api HTTP/1.1" while reading PROXY protocol) and agent scraping failures (EOF).This PR:
proxy_protocolparameter onlistendirectives viahasProxyProtocolArgumentandisProxyProtocolListenDirective.proxy_protocollisten sockets when generating plain HTTP endpoints for/stub_statusand/api.proxy_protocolon port 8888 and standard listener on port 8080 or unix socket) to discover the valid, reachable endpoint.nginx_config_parser_test.go.Closes #978
Checklist
CONTRIBUTINGdocument