Conversation
Required by mdatagen for nginxplusreceiver, nginxreceiver, and containermetricsreceiver metrics. No behaviour change.
Emit nginx.http.upstream.peer.response_time_hist from the NGINX Plus receiver . Update the scraper to perform one targeted GET of /api/<version>/http/upstreams and decode it into a local struct in record/http_upstreams_payload.go. mdatagen does not support the histogram type for receiver metrics. mdatagen v0.157.0 defines a Histogram metadata type, but it is only wired into the internal telemetry instruments; the receiver metrics builder template emits no bucket counts or explicit bounds at all. Declaring the metric as histogram in metadata.yaml therefore produces no usable recorder, and the only type that generates is a scalar gauge, which can carry a single number, not a distribution. nginx-plus-go-client does not expose response_time_hist. response_time_hist does not appear anywhere in the module, so GetStats() silently drops the object during unmarshaling.
github-actions
Bot
added
chore
Contributor
|
🎉 Thank you for your contribution! It appears you have not yet signed the F5 Contributor License Agreement (CLA), which is required for your changes to be incorporated into an F5 Open Source Software (OSS) project. Please kindly read the F5 CLA and reply on a new comment with the following text to agree: I have hereby read the F5 CLA and agree to its terms 1 out of 2 committers have signed the CLA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Emit nginx.http.upstream.peer.response_time_hist from the NGINX Plus
receiver . Update the scraper to perform one targeted GET of /api//http/upstreams
and decode it into a local struct in
record/http_upstreams_payload.go.
mdatagen does not support the histogram type for receiver metrics.
mdatagen v0.157.0 defines a Histogram metadata type, but it is only
wired into the internal telemetry instruments; the receiver metrics
builder template emits no bucket counts or explicit bounds at all.
Declaring the metric as histogram in metadata.yaml therefore produces no
usable recorder, and the only type that generates is a scalar gauge, which can carry a single number, not a distribution.
nginx-plus-go-client does not expose response_time_hist. response_time_hist does not appear anywhere in the module, so GetStats() silently drops the object during unmarshaling.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)