Repository navigation
Don't post an error when the theming product name isn't set yet - #2881
Merged
Merged
Conversation
occ config:app:get exits with 1 if the key doesn't exist, so on a new install check_command told the admin that something went wrong. It only ended the subshell, and the name was set on the next line. Use nextcloud_occ_no_check for the read. Also fix a comment that still said the pool is imported with UUID.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new install posts "Sorry but something went wrong" to the admin, with
occ config:app:get theming productName failed.config:app:getexits with 1 if the key doesn't exist, and on a new install it doesn't yet.nextcloud_occthen runscheck_command, which posts the notification. It only ends the$(...)subshell, so the install carries on and sets the name on the next line. The read now usesnextcloud_occ_no_check, in the install and in the update.Also fixes a comment in
nextcloud-startup-script.shthat still said the pool is imported with UUID.Tested with a fake
occthat exits 1 for that key, not on a full install: the old line posts one notification and the new line posts none, and both go on to set the name. The original notification was seen on a real install.