Skip to content

fix(scheduled-messages): use unique message id as LazyColumn item key - #6597

Merged
mahibi merged 1 commit into
masterfrom
bugfix/noid/fixIllegalArgumentExceptionForScheduledMessages
Aug 27, 2026
Merged

fix(scheduled-messages): use unique message id as LazyColumn item key#6597
mahibi merged 1 commit into
masterfrom
bugfix/noid/fixIllegalArgumentExceptionForScheduledMessages

Conversation

@mahibi

@mahibi mahibi commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

fix the crash:

Exception java.lang.IllegalArgumentException:
  at androidx.compose.ui.internal.InlineClassHelperKt.throwIllegalArgumentException (InlineClassHelper.kt:36)
  at androidx.compose.ui.layout.LayoutNodeSubcompositionsState.subcompose (SubcomposeLayout.kt:1592)
  at androidx.compose.ui.layout.LayoutNodeSubcompositionsState$Scope.subcompose (SubcomposeLayout.kt:1353)
  at androidx.compose.foundation.lazy.layout.LazyLayoutMeasureScopeImpl.compose (LazyLayoutMeasureScope.kt:94)
  at androidx.compose.foundation.lazy.layout.LazyLayoutMeasuredItemProvider.getPlaceables-3p2s80s (LazyLayoutMeasuredItem.kt:118)
  at androidx.compose.foundation.lazy.LazyListMeasuredItemProvider.getAndMeasure-0kLqBqw (LazyListMeasuredItemProvider.kt:54)
  at androidx.compose.foundation.lazy.LazyListMeasuredItemProvider.getAndMeasure-0kLqBqw$default (LazyListMeasuredItemProvider.kt:48)

however i assume there is still some other bug in the app which produces the same issue (given the amount of reports its maybe chatview itself. to be fixed in a separate PR).

馃弫 Checklist

  • 鉀戯笍 Tests (unit and/or integration) are included or not needed
  • 馃敄 Capability is checked or not needed
  • 馃敊 Backport requests are created or not needed: /backport to stable-xx.x
  • 馃搮 Milestone is set
  • 馃尭 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

馃 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@mahibi mahibi added this to the 25.1.0 milestone Aug 27, 2026
@mahibi
mahibi requested a review from rapterjet2004 August 27, 2026 11:25
@mahibi mahibi self-assigned this Aug 27, 2026
@mahibi mahibi added the 3. to review Waiting for reviews label Aug 27, 2026
@mahibi

mahibi commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable-25.0.x

@mahibi

mahibi commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator Author

however i assume there is still some other bug in the app which produces the same issue (given the amount of reports its maybe chatview itself. to be fixed in a separate PR).

most probably commit 1b71ecb from #6327
Using the referenceId when replacing temporary messages with actual messages might have some problems..
-> "fixed" with a9d1533

@github-actions

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/33067320702/artifacts/9647149647
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

fix the crash

Exception java.lang.IllegalArgumentException:
  at androidx.compose.ui.internal.InlineClassHelperKt.throwIllegalArgumentException (InlineClassHelper.kt:36)
  at androidx.compose.ui.layout.LayoutNodeSubcompositionsState.subcompose (SubcomposeLayout.kt:1592)
  at androidx.compose.ui.layout.LayoutNodeSubcompositionsState$Scope.subcompose (SubcomposeLayout.kt:1353)
  at androidx.compose.foundation.lazy.layout.LazyLayoutMeasureScopeImpl.compose (LazyLayoutMeasureScope.kt:94)
  at androidx.compose.foundation.lazy.layout.LazyLayoutMeasuredItemProvider.getPlaceables-3p2s80s (LazyLayoutMeasuredItem.kt:118)
  at androidx.compose.foundation.lazy.LazyListMeasuredItemProvider.getAndMeasure-0kLqBqw (LazyListMeasuredItemProvider.kt:54)
  at androidx.compose.foundation.lazy.LazyListMeasuredItemProvider.getAndMeasure-0kLqBqw$default (LazyListMeasuredItemProvider.kt:48)

Assisted-by: Claude:claude-sonnet-5

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
mahibi force-pushed the bugfix/noid/fixIllegalArgumentExceptionForScheduledMessages branch from 6893a1a to 33d4790 Compare August 27, 2026 15:52
@mahibi
mahibi merged commit 7f07119 into master Aug 27, 2026
13 of 18 checks passed
@mahibi
mahibi deleted the bugfix/noid/fixIllegalArgumentExceptionForScheduledMessages branch August 27, 2026 15:53
@github-actions

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/33090234389/artifacts/9659785958
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews AI assisted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants