Skip to content

fix(files_external): show that an unrestricted storage applies to all - #64103

Open
pringelmann wants to merge 1 commit into
masterfrom
fix/files_external-unrestricted-storage-hint
Open

fix(files_external): show that an unrestricted storage applies to all#64103
pringelmann wants to merge 1 commit into
masterfrom
fix/files_external-unrestricted-storage-hint

Conversation

@pringelmann

@pringelmann pringelmann commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Summary

An admin-configured external storage with an empty "Restricted to" field is available to every account. The problem is that nothing in the UI explicitly says so. The old settings had an "All people" checkbox, ticked by default. The new rewrite dropped it for a bare user/group picker, so an unrestricted mount only appears as an empty input in the form.

Two UI additions:

  • The storage table shows an "All accounts" chip in the "Restricted to" column when a storage has no applicable users or groups.
  • The Add/Edit dialog shows a warning under the picker while it is empty.
Before After
image image
image image

This is deliberately just the hint. No confirmation step on save, that is a separate UX decision.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Screenshots before/after for front-end changes
  • Documentation (manuals or wiki) has been updated or is not required
  • Backports requested where applicable (ex: critical bugfixes)
  • Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
  • Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

  • The content of this PR was partly or fully generated using AI (tests, reviewed)

accounts

Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
@pringelmann pringelmann added this to the Nextcloud 36 milestone Sep 8, 2026
@pringelmann
pringelmann marked this pull request as ready for review September 8, 2026 07:53
@pringelmann
pringelmann requested review from a team and skjnldsv as code owners September 8, 2026 07:53
@pringelmann
pringelmann requested review from kristian-zendato and sorbaugh and removed request for a team September 8, 2026 07:53
@pringelmann

Copy link
Copy Markdown
Contributor Author

/backport to stable35

@pringelmann

Copy link
Copy Markdown
Contributor Author

/backport to stable34

@pringelmann

Copy link
Copy Markdown
Contributor Author

/backport to stable33

@pringelmann pringelmann self-assigned this Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants