fix(files_external): show that an unrestricted storage applies to all - #64103
Open
pringelmann wants to merge 1 commit into
Open
fix(files_external): show that an unrestricted storage applies to all#64103pringelmann wants to merge 1 commit into
pringelmann wants to merge 1 commit into
Conversation
accounts Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
pringelmann
marked this pull request as ready for review
September 8, 2026 07:53
pringelmann
requested review from
kristian-zendato and
sorbaugh
and removed request for
a team
September 8, 2026 07:53
Contributor
Author
|
/backport to stable35 |
Contributor
Author
|
/backport to stable34 |
Contributor
Author
|
/backport to stable33 |
artonge
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An admin-configured external storage with an empty "Restricted to" field is available to every account. The problem is that nothing in the UI explicitly says so. The old settings had an "All people" checkbox, ticked by default. The new rewrite dropped it for a bare user/group picker, so an unrestricted mount only appears as an empty input in the form.
Two UI additions:
This is deliberately just the hint. No confirmation step on save, that is a separate UX decision.
Checklist
3. to review, feature component)stable32)AI (if applicable)