Add Unified Sharing#62241
Conversation
1cb4c66 to
5b3870e
Compare
| * @since 35.0.0 | ||
| */ | ||
| #[Consumable(since: '35.0.0')] | ||
| final readonly class ShareIconSVG { |
There was a problem hiding this comment.
It might make sense to move the icon classes outside the share namespace, so they could be used for non-sharing dynamic icon registration in the future.
| /** @var array<int, array<class-string<IShareRecipientType>, bool>> $shareRecipientTypeClasses */ | ||
| $shareRecipientTypeClasses = []; | ||
| foreach ($chunks as $chunk) { | ||
| $qb = $this->connection->getQueryBuilder(); |
There was a problem hiding this comment.
in most cases, we have already done a query on recipients above when finding share ids, probably worth fetching this data then instead.
There was a problem hiding this comment.
You are right, however implementing this is not very nice, because it duplicates the logic for parsing the recipient rows and also causes rows from sharing_share to be returned multiple times.
So I'm not sure if this is worth fixing, but we can keep it in mind for later if we notice that there is a performance issue that could be solved by this change.
|
@come-nc @icewind1991 I will address the remaining feedback in separate PRs. |
5b3870e to
89464f5
Compare
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
7aa592a to
c682e1e
Compare
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
c682e1e to
1700c71
Compare
provokateurin
added
the
pending documentation
5 participants
Summary
#51803
Checklist
3. to review, feature component)stable32)AI (if applicable)