fix(overview): favourite indicator accessible name, mime-escape comment - #148
Open
moodyjmz wants to merge 2 commits into
Open
fix(overview): favourite indicator accessible name, mime-escape comment#148moodyjmz wants to merge 2 commits into
moodyjmz wants to merge 2 commits into
Conversation
The list-view favourite star (NcIconSvgWrapper) rendered with no `name` prop, so it defaulted to aria-hidden. Favourited status was conveyed by icon and colour alone, with no adjacent text, making it invisible to screen readers. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
The escaping (&, <, >) is complete because it only ever lands inside <d:literal> element text, not an attribute — not because the input is a closed literal set. `mimes` also includes server-registered mimetypes from the templates endpoint, not just this file's own constants, so the safety argument needed to be explicit about where it actually comes from. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NcIconSvgWrapperdefaulted toaria-hiddenwith nonameprop — favourited status was icon+colour only).escapeXmlinofficeFiles.ts— the escaping is safe because it lands in<d:literal>element text, not because the mime list is a closed literal set (it also includes server-registered mimetypes).Test plan
npm run lintnpm run test:unit(new regression test for the favourite indicator's accessible name)npm run build