Skip to content

Conditional questions: branches on linear scale and color - #3837

Open
AndyScherzinger wants to merge 1 commit into
feat/conditional-questions-4-filefrom
feat/conditional-questions-5-scale-color
Open

AndyScherzinger wants to merge 1 commit into
feat/conditional-questions-4-filefrom
feat/conditional-questions-5-scale-color

Conversation

@AndyScherzinger

@AndyScherzinger AndyScherzinger commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Part 5 of the conditional questions stack from #3123 (by Micke Nordin, with fixes by TimedIn and the review fixes). Based on #3836; the "Files changed" tab shows only this part.

Stack

  1. Conditional questions: base with radio and dropdown questions #3833 Conditional questions: base with radio and dropdown questions
  2. Conditional questions: branches on checkboxes #3834 Conditional questions: branches on checkboxes
  3. Conditional questions: branches on date and time #3835 Conditional questions: branches on date and time
  4. Conditional questions: branches on file upload #3836 Conditional questions: branches on file upload
  5. Conditional questions: branches on linear scale and color #3837 Conditional questions: branches on linear scale and color ← this PR
  6. Conditional questions: branches on short and long text #3838 Conditional questions: branches on short and long text

This PR

A linear scale question shows a branch when its value equals, does not equal, lies within a range, or is above a minimum or below a maximum. A color question shows a branch when the color matches, ignoring case.

  • condition matching on the server and in the browser;
  • the value and range inputs and the color picker in the condition editor; the color button names the selected color for screen readers;
  • docs and tests.

Tests

  • Unit tests: 645, all passing except the 15 IUserFolder errors main has as well.
  • php-cs-fixer, psalm, eslint, vue-tsc (no new errors) and the build are clean.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@codecov

codecov Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
lib/Service/SubmissionService.php 90.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-5-scale-color branch from 624a98f to 5734f04 Compare November 4, 2026 14:07
@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-4-file branch 2 times, most recently from 21c5283 to fe30885 Compare November 4, 2026 14:20
@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-5-scale-color branch from 5734f04 to 6e7c64d Compare November 4, 2026 14:20
@timedin-de

Copy link
Copy Markdown

Sorry i didnt have the time to check it currently. But my two cents regarding trigger. For my use case we would need the linear scale as a number input for higher/lower than, which is not possible using choice/options (and is not ideal using number input), for a "How many people do you want to signup" (with Name etc per Person).

Thats why i would seperate it from color, as i See no real usecase for color trigger (except some specific quizzes or sth, and then its also possible to use the choice or Text input)

@Chartman123

Copy link
Copy Markdown
Collaborator

@timedin-de did you already have a look at this feature request? #1728

For me, it sounds a bit more like this is what you would like to achieve?

@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-4-file branch from fe30885 to f1898c5 Compare November 4, 2026 16:51
@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-5-scale-color branch from 6e7c64d to 7124f48 Compare November 4, 2026 16:51
@timedin-de

Copy link
Copy Markdown

@timedin-de did you already have a look at this feature request? #1728

For me, it sounds a bit more like this is what you would like to achieve?

Yes a proper implementation would probably be better, but as you already posted there, its a rather complicated edge case probably not beeing implemented in near future.

My case was just this workaround (similar to our current Google forms, [in Gforms we use a nested checkbox "you want to signup more people?]), was:

"How many attendants" (1-5)
Name 1
Adress 1
if attendants > 1:
Name 2
Adress 2
if attendants > 2:
....

@Chartman123

Copy link
Copy Markdown
Collaborator

Ok, but why would you need the linear scale then instead of the radio question?

@timedin-de

timedin-de commented Nov 4, 2026 •

Copy link
Copy Markdown

Ok, but why would you need the linear scale then instead of the radio question?

I guess Radio doesnt support < and > (so in this use case you would need to have 1 Participant in Branch one, 2 Participants in Branch 2 etc.

With < you only need one new Participant per Branch

Branch 1: Name 1
Branch 2: Name 1 and Name 2

vs
Branch 1: Name 1
Branch 2: Name2

@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-5-scale-color branch from 7124f48 to bdd436e Compare November 5, 2026 11:10
@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-4-file branch 2 times, most recently from b287cc5 to 9214258 Compare November 7, 2026 15:29
@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-5-scale-color branch from bdd436e to 8e890c3 Compare November 7, 2026 15:29
@AndyScherzinger AndyScherzinger changed the title Conditional questions: linear scale and color as trigger Conditional questions: branches on linear scale and color Nov 7, 2026
@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-5-scale-color branch from 8e890c3 to 97c9416 Compare November 7, 2026 15:41
@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-4-file branch from 9214258 to 2e47a17 Compare November 7, 2026 15:41
@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-5-scale-color branch from 97c9416 to d00994a Compare November 7, 2026 17:59
@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-4-file branch from 2e47a17 to b8de1b0 Compare November 8, 2026 18:03
@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-5-scale-color branch from d00994a to b64e46f Compare November 8, 2026 18:03
A linear scale question opens a branch when its value equals, does not
equal, lies within a range, or is above a minimum or below a maximum.
A color question opens a branch when the color matches, ignoring case.
The color button names the selected color for screen readers.

The code comes from the original pull request #3123 by Micke Nordin
and TimedIn, with the review fixes applied.

Assisted-by: Claude Code:claude-opus-5-5
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-5-scale-color branch from b64e46f to 6122c00 Compare November 9, 2026 11:40
@AndyScherzinger
AndyScherzinger force-pushed the feat/conditional-questions-4-file branch from b8de1b0 to c5f88a4 Compare November 9, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants