Skip to content

fix: only send a single submission notification per user#3363

Merged
Chartman123 merged 1 commit into
mainfrom
fix/notify-submission
May 27, 2026
Merged

fix: only send a single submission notification per user#3363
Chartman123 merged 1 commit into
mainfrom
fix/notify-submission

Conversation

@Chartman123
Copy link
Copy Markdown
Collaborator

This deduplicates submission notifications by aggregating affected users and sending a single shared-submission activity per unique user, excluding the form owner so they only get the main submission notification.

Signed-off-by: Christian Hartmann chris-hartmann@gmx.de

@Chartman123 Chartman123 added bug Something isn't working 3. to review Waiting for reviews labels May 26, 2026
@Chartman123 Chartman123 added this to the 5.3 milestone May 26, 2026
@Chartman123 Chartman123 requested review from Koc, pringelmann and susnux May 26, 2026 15:41
@Chartman123 Chartman123 self-assigned this May 26, 2026
@Chartman123 Chartman123 changed the title fix: only send one submission notification per user fix: only send a single submission notification per user May 26, 2026
@Chartman123 Chartman123 force-pushed the fix/notify-submission branch 2 times, most recently from c13a34e to d5b3448 Compare May 26, 2026 16:19
@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

❌ Patch coverage is 82.05128% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
lib/Service/FormsService.php 73.07% 7 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Chartman123 Chartman123 force-pushed the fix/notify-submission branch 2 times, most recently from 2712901 to fc1f70a Compare May 26, 2026 17:22
Comment thread lib/Service/FormsService.php Outdated
Comment thread tests/Unit/Service/FormsServiceTest.php
@Chartman123 Chartman123 force-pushed the fix/notify-submission branch from fc1f70a to d04f201 Compare May 27, 2026 11:58
Signed-off-by: Christian Hartmann <chris-hartmann@gmx.de>
@Chartman123 Chartman123 force-pushed the fix/notify-submission branch from 830c0c6 to 5d9eed8 Compare May 27, 2026 13:23
@Chartman123 Chartman123 merged commit 794c3f4 into main May 27, 2026
55 of 59 checks passed
@Chartman123 Chartman123 deleted the fix/notify-submission branch May 27, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working feature: 🔔 notifications/mails

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants