Repository navigation
Conversation
Assisted-by: Cursor:grok-4.7 Signed-off-by: whoalin1 <whoalin414@gmail.com>
c348221 to
789e2ae
Compare
|
Make sense to me, but I'll wait for other approvals |
come-nc
left a comment
There was a problem hiding this comment.
No, the standard attribute from PHP should be used instead nowadays: https://www.php.net/manual/en/class.sensitiveparameter.php
We should deprecate our custom implementation for this and rely on this standard mechanism as well for core functions. (We can since we dropped 8.1 support in 33)
|
See nextcloud/server#65412 to fully support SensitiveParameter and deprecate registerSensitiveMethods. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
…iveMethods() registerSensitiveMethods() is deprecated since Nextcloud 36 (nextcloud/server#65412); document the standard PHP attribute instead. Assisted-by: Cursor:grok-4.7 Signed-off-by: whoalin1 <whoalin414@gmail.com>
|
@come-nc thanks, makes sense. Now that nextcloud/server#65412 is merged, I reworked the section in e7cdeea. It now recommends AI disclosure: this reply and the change were drafted with help from an AI assistant. |
Summary
Documents how app authors keep secrets out of logged exception stack traces in
developer_manual/basics/logging.rst.#[\SensitiveParameter]attribute, with a short example.deprecated:: 36note forIRegistrationContext::registerSensitiveMethods().Closes #15680
sphinx-lintpasses locally on the changed file. I have not run the full Sphinx build.AI disclosure
This PR was drafted with the help of AI coding assistants (Cursor agents / LLM-based tools), including the description. I am responsible for it and happy to rework anything that doesn't fit.
All commits carry an
Assisted-by: Cursor:grok-4.7trailer.