-
Notifications
You must be signed in to change notification settings - Fork 2.5k
docs: Clarify app icon instructions, add link to Material Symbols & Icons #15321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -185,8 +185,9 @@ Element sizes and spacing | |
| Icons | ||
| ----- | ||
|
|
||
| Icons can be used to communicate the intent of an action, or to provide visual interest to an element. On the browser always use Material Symbols (outlined, 20px). | ||
| Icons can be used to communicate the intent of an action, or to provide visual interest to an element. On the browser always use `Material Symbols <https://fonts.google.com/icons>`__ (outlined, 20px). | ||
|
|
||
| - Never use a custom icon except for the icon of the app itself. Still, most apps use an app icon from Material Symbols to keep consistency. | ||
| - Never use a custom icon except for the icon of the app itself. | ||
| - When possible, use text together with icons so it’s clear what they refer to. | ||
| - For the main app icon, you can use a custom icon or just pick a fitting one from `Material Symbols <https://fonts.google.com/icons>`__ to keep consistency. While the interface icons should be outlined, we recommend using the filled version for the main app icon so it stands out better, also on the header background which can be an image and/or themed. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. are there also some recommendations for custom app icons? Should they also be filled versions? Or should the provide more than one variant (light, dark)?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No recommendations (yet). Usually people would simply use their logo, like e.g. for Zammad. I'm not sure if technically the white monochrome version suffices. @susnux @ShGKme do you know? Either way I would suggest merging this, as we can add any custom app icon clarifications afterwards and it's not a blocker.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
We invert the icon automatically on dark.
I'd say:
I'll double-check if we support anything like a "no-modifications" flag on the app icon.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Nothing on the server side to mark an icon as "modifications not allowed"...
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Here I wasn't entirely correct. We do invert automatically on the web frontend. However, we have some places on the server-side where we expect a direct link to the dark and light icons. So, both are needed. |
||
| - Elements that contain AI-generated content should have a clear indication that they are AI-generated in the form of a written disclaimer or by the use of the Assistant icon ('creation' in Material Symbols) in the Assistant color. | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently we use
Material Design Icons, notSymbolsin the most of the places. Just because 2 libraries we are using provide them.Though, many icons are identical.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, but this is not anything new in this change? I'm a bit hesitant to link to Pictogrammers as it's non-standard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is now a link to the font, which, IMO, might be confusing (one of the differences between Material Design Symbols and Material Design Icons was targeting variable fonts).
Maybe clarity that SVG is to be used?