Skip to content

Add new cards to top or bottom#8181

Open
theoholl wants to merge 16 commits into
mainfrom
add-new-cards-to-top-or-bottom
Open

Add new cards to top or bottom#8181
theoholl wants to merge 16 commits into
mainfrom
add-new-cards-to-top-or-bottom

Conversation

@theoholl

@theoholl theoholl commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Users can now toggle between adding cards to the top or the bottom of the stack. There is a new 'Add card' button that is on the side of the stack where the new card will be added. Settings has an option to toggle between adding new cards to the top or adding them to the bottom of the stack.

The default settings remains adding cards to the bottom of the stack.

Settings toggle for changing between adding cards to the top or the bottom of the stack:

image

Adding cards to the top of the stack:

image

Adding cards to the bottom of the stack:

image

Note: When using the 'add card to bottom of list' option, a dragged card must be dragged above the 'Add card' button and not within the whole height of the list like it when using the 'add card to top of list' option. I think this okay but it's a behavior change and worth thinking about.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

theoholl added 11 commits July 19, 2026 10:41
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…but make it stick in visible area on overflow

Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…image` was cutting of dragged cards.

Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…or-bottom

# Conflicts:
#	src/components/board/Stack.vue
…s set to 'add to bottom'

Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
@theoholl
theoholl marked this pull request as ready for review July 19, 2026 17:16
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
@theoholl
theoholl force-pushed the add-new-cards-to-top-or-bottom branch from e5aa08a to 050a23d Compare July 20, 2026 07:55
@theoholl
theoholl force-pushed the add-new-cards-to-top-or-bottom branch from f911c83 to 7d7651c Compare July 20, 2026 09:27
@github-actions

Copy link
Copy Markdown
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 96814 was 96706 (+0.11%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
@theoholl
theoholl force-pushed the add-new-cards-to-top-or-bottom branch from 7d7651c to bcaea9d Compare July 20, 2026 09:42

@grnd-alt grnd-alt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
I like the idea in general but I think the implementation is way to complex. For a sticky element like that we shouldn't need that much js, I don't think we need a resizeObserver and bottomAddCardInline for example. For the handling with empty stacks, we could only use the isEmptyStack and remove isEmptyStackWithBottomAddCard, please also have a look at the other js parts of this pr to simplify it further.

some ui things I noticed:

  • you can't really drag and drop to empty stacks as the dnd container shrinks
  • when clicking "add card" the input gets bigger/wider which causes a sudden layout shift, would be nice to not have that
  • subjective but I think having the "add card" with less opacity might look nicer to not draw away attention from the cards already there

@theoholl

Copy link
Copy Markdown
Contributor Author

Completely agreed, I'll work on that. Thanks for your review! :)

theoholl added 2 commits July 22, 2026 13:07
Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
…op mode

Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 96846 was 96706 (+0.14%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New cards are created at the bottom of the screen

2 participants