Repository navigation
Conversation
f9f3eb4 to
286de13
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
| // watch url change and address book select | ||
| selectedAddressbook() { | ||
| if (!this.isMobile && !this.selectedChart) { | ||
| if (this.addressbook && !this.isMobile && !this.selectedChart) { |
There was a problem hiding this comment.
Is this leftover ? this.addressbookis always underfined
There was a problem hiding this comment.
No it's the actual fix. The reason is as follows: The 'External invitations' route does not have the addressbook part so when navigating to it from any of the Address books lists this.addressbook changes to undefined and the selectedAddressbook() watcher is triggered. And then selectFirstContactIfNone() is called (causing the group not found error) instead of selectFirstOcmInviteIfNone().
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Signed-off-by: Antoon P. <antoon.prins@surf.nl>
286de13 to
f4a6a2c
Compare
The OCM invites routes lack the addressbook part. That Irregularly causes a
group not founderror when navigating from any of the Address book contacts lists to 'External invitations' list.This PR fixes this issue by checking if `this.addressbook` is actually set in the relevant watcher.