Skip to content

refactor(intent): simplify deep link and file intent handling - #17888

Open
alperozturk96 wants to merge 5 commits into
masterfrom
refactor/deep-link-file-intent-handling
Open

refactor(intent): simplify deep link and file intent handling#17888
alperozturk96 wants to merge 5 commits into
masterfrom
refactor/deep-link-file-intent-handling

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Oct 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Issue

  • Opening a file link from Talk (…/f/) showed "Associated account not found".
  • The link's server was compared with each account's saved server URL as an exact string, so letter case, a trailing /, /index.php, default ports or http vs https made it fail.

Android Common PR: nextcloud/android-common#1093

Android Talk PR: nextcloud/talk-android#6956

How to test?

  • Open account from Talk
  • Open same account in Files
  • Tap file link from Talk
  • It should open file in Files

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

@alperozturk96 alperozturk96 changed the title Refactor/deep link file intent handling refactor(intent): simplify deep link and file intent handling Oct 27, 2026
This was referenced Oct 27, 2026
Merged
Merged
@alperozturk96 alperozturk96 linked an issue Oct 27, 2026 that may be closed by this pull request
opening file links from talk -> error #17573
Open
@alperozturk96 alperozturk96 mentioned this pull request Oct 27, 2026
Open
@codecov

codecov Bot commented Oct 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 37.50000% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...xtcloud/client/account/UserAccountManagerImpl.java 40.00% 2 Missing and 4 partials ⚠️
...ndroid/providers/UsersAndGroupsSearchProvider.java 0.00% 4 Missing ⚠️
.../java/com/owncloud/android/ui/AvatarGroupLayout.kt 50.00% 2 Missing ⚠️
...m/nextcloud/client/account/UserAccountManager.java 0.00% 1 Missing ⚠️
...m/owncloud/android/ui/adapter/ShareeListAdapter.kt 0.00% 1 Missing ⚠️
...ud/android/ui/fragment/ProfileBottomSheetDialog.kt 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

tobiasKaminsky
tobiasKaminsky previously requested changes Oct 28, 2026
View reviewed changes
Comment thread app/src/main/java/com/nextcloud/client/account/UserAccountManagerImpl.java
return true;
}

String userId = accountManager.getUserData(account, AccountUtils.Constants.KEY_USER_ID);

@tobiasKaminsky tobiasKaminsky Oct 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the key_user_id always the same like account.name?
I think this can be different.
Account can be tobias@mail.com@server.com
-> name tobias@mail.com
-> userId (internal userid from server) might then be tobias or ldap id.

@alperozturk96 alperozturk96 Oct 28, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KEY_USER_ID is not same like account.name always and this is right comparison. Otherwise it will fail like old code.

see, this only set via authenticator code:

Image

Old code should fail via LDAP for example. We are checking here file belongs this account or not that's all.

Comment thread gradle/libs.versions.toml Outdated

[versions]
androidCommonLibraryVersion = "0.34.0"
androidCommonLibraryVersion = "f6515c1c36"

@tobiasKaminsky tobiasKaminsky Oct 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: change after merging upstream?

@alperozturk96
alperozturk96 force-pushed the refactor/deep-link-file-intent-handling branch from 0b48676 to 873ad22 Compare October 28, 2026 08:11
@alperozturk96
alperozturk96 force-pushed the refactor/deep-link-file-intent-handling branch from 873ad22 to fe7f345 Compare October 28, 2026 12:14
daniele-verducci
daniele-verducci approved these changes Oct 28, 2026
View reviewed changes

@daniele-verducci daniele-verducci left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested like we did in call and it works. User id comparison make sense to me (based on what we have seen in the debugger)

@alperozturk96

alperozturk96 commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator Author

Tested like we did in call and it works. User id comparison make sense to me (based on what we have seen in the debugger)

nextcloud/android-common#1093

can i get review for common also :)

@alperozturk96
alperozturk96 force-pushed the refactor/deep-link-file-intent-handling branch from fe7f345 to 57a4594 Compare October 30, 2026 12:25
@alperozturk96
alperozturk96 force-pushed the refactor/deep-link-file-intent-handling branch from 57a4594 to 8e23590 Compare November 13, 2026 09:13
@github-actions

github-actions Bot commented Nov 13, 2026

Copy link
Copy Markdown

stable22-IT test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

github-actions Bot commented Nov 13, 2026

Copy link
Copy Markdown

stable35-IT test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

github-actions Bot commented Nov 13, 2026

Copy link
Copy Markdown

master-IT test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions

github-actions Bot commented Nov 13, 2026 •
edited
Loading

Copy link
Copy Markdown

📱 QA build
Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 254653f
Version 17888
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@alperozturk96
fix(account-name): parsing
ac781ea 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
refactor(intent): simplify deep link and file intent handling
9deeb3b 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
Without a user ID there is nothing reliable to compare ownerId agains…
e9b921d 
…t thus use is shared with me

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
update lib
590e3ff 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
254653f 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
alperozturk96 force-pushed the refactor/deep-link-file-intent-handling branch from 47e2950 to 254653f Compare November 13, 2026 15:07
@github-actions

github-actions Bot commented Nov 13, 2026

Copy link
Copy Markdown

SpotBugs

CategoryBaseNew
Bad practice2424
Correctness4646
Dodgy code125118
Experimental11
Malicious code vulnerability11
Multithreaded correctness1313
Performance2525
Security1515
Total250243

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniele-verducci daniele-verducci daniele-verducci approved these changes
@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees

No one assigned

Labels

3. to review AI assisted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

opening file links from talk -> error

3 participants

@alperozturk96 @tobiasKaminsky @daniele-verducci