Allow icon-only and clear-at-only status updates - #17562
Open
ibrahim-iqbal wants to merge 1 commit into
Open
Conversation
The server rejects a status update whose message field is empty, even when the caller is only changing the icon or clearAt. Substitute a single space so those single-field updates go through, matching the fix applied in nextcloud/talk-android@a89c5952fa. Fixes nextcloud#9855 Signed-off-by: ibrahim-iqbal <199698216+ibrahim-iqbal@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9855.
The server rejects a status update whose message field is empty, even when the caller is only changing the icon or the clear-at time. That silently blocks the "only icon" and "only clear at" paths from the status dialog.
Substituting a single space when the input is empty lets the API accept those single-field updates, matching the fix that was already applied on the talk-android side: nextcloud/talk-android@a89c5952fa.
Repro (from the issue)
Before: dialog closes but neither the icon nor the clear-at value is persisted.
After: the chosen icon and/or clear-at is stored server-side; the message field shows as a single space, which is what talk-android has been shipping for the same reason.