feat(unified-share): ui

[alperozturk96]

Common Library PR: nextcloud/android-common#939

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

[github-actions]

APK file: https://github.com/nextcloud/android/actions/runs/33870393259/artifacts/9935824030
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
(please click on link to get QR code displayed)

[github-actions]

Codacy

SpotBugs

Category	Base	New
Bad practice	35	35
Correctness	58	58
Dodgy code	202	202
Experimental	1	1
Malicious code vulnerability	2	2
Multithreaded correctness	26	26
Performance	37	37
Security	19	19
Total	380	380

[github-actions]

master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/16865-IT-master-12-23

[daniele-verducci]

Testing results

Share list

• When a share is added and then the list is reloaded (i.e. with pull-to-refresh), the list is rearranged in a different order
• On small screens, it's impossible to see the list in landscape, and the view can't be scrolled if at least some of the list isn't visible (to reproduce: Pixel 10 emulator, Android 17, default settings):

• In landscape, the date dialog isn't useable, the calendar inside it doesn't scroll and it's cut (to reproduce: Pixel 10 emulator, Android 17, default settings):

• If the last item in the list is a share with multiple recipients, there's no way to expand it to change single recipients settings, as the FAB is over the expansion button:

Invited people (Internal)

• It is possible to create two identical shares (same person, same permissions, same settings)

Anyone (External)

• Links created with Anyone are not working, if opened show "Share not found" (probably server-side issue)

[daniele-verducci]

Hey @alperozturk96 ,
done a fair amount of testing and found nothing really blocking (see the previous comment). Thus I approve, but if you should decide to fix a single item in the previous list, I'd suggest it to be the FAB covering the last row expansion button. Maybe it's enough to just add some margin to the last row...