[stable34] refactor(types): add native parameter and return types to UserSettings#2614
Merged
Merged
Conversation
miaulalala
approved these changes
May 20, 2026
Activity
 |
|||||||||||||||||||||||||||||||||||||||||||
| Project |
Activity
|
| Branch Review |
backport/2572/stable34
|
| Run status |
|
| Run duration | 02m 18s |
| Commit |
|
| Committer | backportbot[bot] |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
3
|
 |
0
|
 |
1
|
 |
0
|
 |
6
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
| Test | Artifacts | |
|---|---|---|
| Check activity listing in the sidebar > Has favorite activity |
Test Replay
Screenshots
|
|
| Check activity listing in the sidebar > Has tag activity |
Test Replay
Screenshots
|
|
| Test | Artifacts | |
|---|---|---|
| Check that user's settings survive a reload > Form survive a reload |
Test Replay
Screenshots
|
|
miaulalala
force-pushed
the
backport/2572/stable34
branch
from
d4cb9d6 to
534fdff
Compare
All six public/protected methods now carry PHP 8.x native types instead of relying on docblocks alone. Two test mocks that used willReturnMap were migrated to willReturnCallback so they return a typed default (false / []) instead of null when no entry matches. Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
miaulalala
force-pushed
the
backport/2572/stable34
branch
from
534fdff to
0a386cf
Compare
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #2572