feat: add deleteBy, batched auto-save, source roundtrip#1
Merged
Conversation
Contributor
|
Thank you Daniele for the contribution. I thought to simplify the usage of this component managing the creation of a new database or loading an exsting one automatically inside the PHPVector class. So now the adapter just get the path of the directory to store database information instead of forcing developers to implement the check logic: class MyRAG extends RAG
{
...
protected function vectorStore(): VectorStoreInterface
{
return new PHPVector(
path: '/var/data/mydb',
topK: 5,
);
}
}Here is the code: https://github.com/neuron-core/php-vector/blob/main/src/PHPVector.php#L33-L41 Let me know what you think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements
deleteBy(sourceType, ?sourceName)and a few supporting changes, as discussed on ezimuel/PHPVector#7.PHPVector exposes the primitives (
metadataSearch()from #4,deleteDocument()from #3), so this PR composes them.No
neuron-core/neuron-aidependency is added to PHPVector.Changes
sourceType/sourceNameround-trip: folded into PHPVector metadata as reserved keys on write; restored and stripped frommetadataon read insimilaritySearch. EnablesdeleteByto filter on them.deleteBy(sourceType, ?sourceName): builds an ANDedMetadataFilterlist, runsmetadataSearch, deletes each match viadeleteDocument, thenpersist().deleteBySource(...)(deprecated by the interface) becomes a one-line delegate.bool \$autoSave = trueconstructor flag;persist()callssave()once per public mutation, gated by\$autoSave && \$database->isPersistent()so in-memory databases are skipped. The pre-existing manual-save path is kept on a single test.autoSave, deletion.Dependency
Requires
ezimuel/phpvector ^0.3.0(now stable on Packagist).