Conversation
…sent and type annotation updates
huacchob
requested review from
itdependsnetworks,
jeffkala and
qduk
as code owners
July 20, 2026 15:44
jeffkala
reviewed
Aug 10, 2026
|
|
||
|
|
||
| class OsPlatform(metaclass=abc.ABCMeta): | ||
| class OsPlatform(abc.ABC): |
Collaborator
There was a problem hiding this comment.
so largely this is the only actual change? All the mypy typing changes are not needed? Just updates based on newer floor of python version?
Contributor
Author
There was a problem hiding this comment.
The change I actually want to implement is in netutils.nist.py line 221 https://github.com/networktocode/netutils/pull/862/changes#diff-e90ca65a37a941e8f2767f35f4b6483dbccc5fb9ca85d74dcc904bb28ac7a748R221
This skips adding the "Error" key to the field_values dict.
This is the error I get when the "Error" key is present:
[12:43:55.465] There was an error in creating URLs for this Software Version. Please check the version value for Cisco cisco_ios 03.03.05SE. ERROR: CiscoIos.__init__() got an unexpected keyword argument 'Error'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…sent and type annotation updates