Repository navigation
Supply explicit passwords for encrypted Lambda test fixtures - #194
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encrypted Basic Auth and API-key test fixtures fail after light-4j removes AutoAESSaltDecryptor's JUnit password fallback. LambdaApp/Handler startup tests also construct those middleware providers, so their initialization fails and leaves later tests with null handler chains.
Supply the synthetic fixture password with JUnit's scoped SetSystemProperty annotation on the 14 Java test classes that load the encrypted fixtures directly or initialize the configured handler chain. JUnit restores the previous property automatically. The diff adds only test imports and annotations; no production, fixture-resource, or POM changes.
Validation on master against the updated light-4j snapshot:
mvn -o clean testwith both runtime-password environment variables absent: 110 tests, zero failures/errors, 4 existing skips.-DreuseForks=false) with both runtime-password environment variables set to a different synthetic password: 43 tests, zero failures/errors/skips.Companion to networknt/light-4j#2832; uses the same test-local fixture migration as networknt/light-rest-4j#454 and networknt/light-rest-4j#455.