Skip to content

Supply explicit passwords for encrypted Lambda test fixtures - #194

Merged
stevehu merged 1 commit into
masterfrom
fix/explicit-security-fixture-password
Oct 29, 2026
Merged

stevehu merged 1 commit into
masterfrom
fix/explicit-security-fixture-password

Conversation

@stevehu

@stevehu stevehu commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Encrypted Basic Auth and API-key test fixtures fail after light-4j removes AutoAESSaltDecryptor's JUnit password fallback. LambdaApp/Handler startup tests also construct those middleware providers, so their initialization fails and leaves later tests with null handler chains.

Supply the synthetic fixture password with JUnit's scoped SetSystemProperty annotation on the 14 Java test classes that load the encrypted fixtures directly or initialize the configured handler chain. JUnit restores the previous property automatically. The diff adds only test imports and annotations; no production, fixture-resource, or POM changes.

Validation on master against the updated light-4j snapshot:

  • Reproduced BasicAnonymousBearerTest failing all four methods with "No configuration master password supplied" before the fix.
  • Full offline mvn -o clean test with both runtime-password environment variables absent: 110 tests, zero failures/errors, 4 existing skips.
  • All 14 affected classes run in separate JVMs (-DreuseForks=false) with both runtime-password environment variables set to a different synthetic password: 43 tests, zero failures/errors/skips.
  • GitNexus change review reports low risk and test-only scope.

Companion to networknt/light-4j#2832; uses the same test-local fixture migration as networknt/light-rest-4j#454 and networknt/light-rest-4j#455.

Copilot AI balanced review requested due to automatic review settings October 29, 2026 21:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@stevehu
stevehu merged commit 61fb582 into master Oct 29, 2026
1 check passed
@stevehu
stevehu deleted the fix/explicit-security-fixture-password branch October 30, 2026 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants