test: setup local e2e tests that use playwright to inspect actual requests being made - #44
test: setup local e2e tests that use playwright to inspect actual requests being made#44pieh wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| if (!app) { | ||
| app = document.createElement('div') | ||
| app.id = 'app' | ||
| document.body.prepend(app) | ||
| } |
There was a problem hiding this comment.
rollup html plugin doesn't use index.html as a template so it produces generic html without mount point (with script pointing to entry). There is community (?) plugin https://modern-web.dev/docs/building/rollup-plugin-html/ that would do it, but it doesn't work with rolldown
Add simple test using playwright to #40 that captures requests and ensures they are fingerprinted with
?nfdpl=.This should ensure a bit more confidence inspiring "e2e test" rather than trigerring a build and just searching for
?nfdpl=string in outputs.