Skip to content

ci: don't special case node version in workflow, instead skip tests in angular package - #42

Merged
pieh merged 5 commits into
mainfrom
ci/skip-angular-tests-in-package-not-workflow
Aug 20, 2026
Merged

ci: don't special case node version in workflow, instead skip tests in angular package#42
pieh merged 5 commits into
mainfrom
ci/skip-angular-tests-in-package-not-workflow

Conversation

@pieh

@pieh pieh commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

The angular-runtime exclusion in GHA workflow we have make it easy to miss adding new packages to special case (like in #40 which adds a package that declares node@20 support, but tests did not run on that version)

This removes special casing from the workflow and instead adds skip to angular-runtime itself

@pieh
pieh requested a review from a team as a code owner August 20, 2026 10:47
@netlify

netlify Bot commented Aug 20, 2026

Copy link
Copy Markdown

Deploy Preview for angular-runtime-demo ready!

Name Link
🔨 Latest commit 284b41a
🔍 Latest deploy log https://app.netlify.com/projects/angular-runtime-demo/deploys/6a8719bbdb300a00089d73a4
😎 Deploy Preview https://deploy-preview-42--angular-runtime-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5534310a-2b2a-4178-8f9a-6268000a7ad4

📥 Commits

Reviewing files that changed from the base of the PR and between 480aaac and 284b41a.

📒 Files selected for processing (3)
  • .github/workflows/test.yaml
  • packages/angular-runtime/package.json
  • packages/angular-runtime/tools/skip-unsupported-node.js
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • netlify/blueprints (manual)

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Improved test execution across supported Node.js versions.
    • Packages requiring unsupported Node.js versions now skip tests automatically with a clear message.
    • Workspace test runs are more consistent across the supported environment matrix.

Walkthrough

The workflow now runs npm run test --workspaces=true for every matrix entry. The Angular runtime package checks the Node version before preparing fixtures or running tests. A new script compares the current Node version with the package engine range and skips unsupported versions successfully.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 284b4

This localized CI change is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

Suggested reviewers: hrishikesh-k, serhalp, eduardoboucas

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the workflow change and the move of test skipping into the Angular package.
Description check ✅ Passed The description explains why the workflow special case was removed and why tests now skip within angular-runtime.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/skip-angular-tests-in-package-not-workflow

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/angular-runtime/package.json

typescript-eslint does not support TS 7.0.
Please see https://devblogs.microsoft.com/typescript/announcing-typescript-7-0/#running-side-by-side-with-typescript-6.0 to run typescript-eslint using the TS 6 API.
See also typescript-eslint/typescript-eslint#10940 for tracking typescript-eslint's support for TS >=7.1

Oops! Something went wrong! :(

ESLint: 9.39.5

Error: typescript-eslint does not support TS 7.0.
at Object. (/node_modules/typescript-eslint/dist/index.js:52:11)
at Module._compile (node:internal/modules/cjs/loader:1830:14)
at Object..js (node:internal/modules/cjs/loader:1961:10)
at Module.load (node:internal/modules/cjs/loader:1553:32)
at Module._load (node:internal/modules/cjs/loader:1355:12)
at wrapModuleLoad (node:internal/modules/cjs/loader:255:19)
at loadCJSModuleWithModuleLoad (node:internal/modules/esm/translators:326:3)
at ModuleWrap. (node:internal/modules/esm/translators:231:7)
at ModuleJob.run (node:internal/modules/esm/module_job:437:25)
at async node:internal/modules/esm/loader:639:26

packages/angular-runtime/tools/skip-unsupported-node.js

ESLint skipped: the matched ESLint configuration already failed (config-incompatibility).


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pieh
pieh enabled auto-merge (squash) August 20, 2026 15:54
@pieh
pieh merged commit da8c3ed into main Aug 20, 2026
24 of 26 checks passed
@pieh
pieh deleted the ci/skip-angular-tests-in-package-not-workflow branch August 20, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants