Repository navigation
Editor surface tokens, field surface look and faster Select menus (v5.8.0) - #653
Merged
Merged
Conversation
- Theme: editor accent, modal backdrop and related tokens for both themes. - Field surface: fieldSurface, fieldHalo, fieldHaloShadow and chevronMark mixins; appearance="surface" on Select and TextInput; selectSurfaceStyles exported for composed controls. - Select: option hover is a CSS rule instead of react-select state, so pointing no longer re-renders the menu; grouped options are virtualized as rows with the group heading pinned while scrolling; lists up to 200 rows mount fully; menuFooter renders below the scroll area. - Vertical tabs: the selected tab uses body text on the segmented selected background with the primary left bar. - Toggle, ButtonGroup and dropdown items take the Sage editor colours.
kapantzak
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the visual decisions of the Dyncfg editor rework (netdata/cloud-frontend#6002) into the kit, so the app can drop its local colour variables and select skins.
Theme
editorAccent,chipBorder,tableRowBorder,modalBackdrop,dialogShadow,stripShadow,logoTileBackground,searchMatchBackground,thresholdWarningBand/Zone,thresholdCriticalBand/Zone.controlBorder,buttonNeutralBorder,inputBorderHover,segmentedSelectedBackground,segmentedAccentText,tableRowBgHover.Controls
fieldSurface,fieldHalo,fieldHaloShadow,fieldSurfaceRound,chevronMark.appearance="surface"onSelectandTextInput;selectSurfaceStyles(theme)is exported for composed controls.text.surfaceargument ofgetDropdownOptionColorsis removed.segmentedSelectedBackgroundwith the primary left bar.Select menus
isFocused.menuFooterprop renders below the scroll area.components.Optionis wrapped so it also skips the hover handlers.Verification
yarn test: 175 suites, 1,993 tests pass.yarn to-cloud; its four CI shards pass on this build.