Skip to content

Editor surface tokens, field surface look and faster Select menus (v5.8.0) - #653

Merged
novykh merged 2 commits into
masterfrom
feat/sage-editor-hierarchy
Nov 17, 2026
Merged

novykh merged 2 commits into
masterfrom
feat/sage-editor-hierarchy

Conversation

@novykh

@novykh novykh commented Nov 17, 2026

Copy link
Copy Markdown
Member

Moves the visual decisions of the Dyncfg editor rework (netdata/cloud-frontend#6002) into the kit, so the app can drop its local colour variables and select skins.

Theme

  • New tokens in both themes: editorAccent, chipBorder, tableRowBorder, modalBackdrop, dialogShadow, stripShadow, logoTileBackground, searchMatchBackground, thresholdWarningBand/Zone, thresholdCriticalBand/Zone.
  • Changed values of existing tokens, which affects every consumer: controlBorder, buttonNeutralBorder, inputBorderHover, segmentedSelectedBackground, segmentedAccentText, tableRowBgHover.

Controls

  • Field surface mixins: fieldSurface, fieldHalo, fieldHaloShadow, fieldSurfaceRound, chevronMark.
  • appearance="surface" on Select and TextInput; selectSurfaceStyles(theme) is exported for composed controls.
  • Toggle (outline), segmented buttons and raised tabs ink the selected state with text.
  • Dropdown options: hover and pressed use table-row tones; the surface argument of getDropdownOptionColors is removed.
  • Vertical tabs: the selected tab is body text on segmentedSelectedBackground with the primary left bar.

Select menus

  • Option hover is a CSS rule instead of react-select focus state, so moving the pointer no longer re-renders the menu and rebuilds every option label. Keyboard focus still drives isFocused.
  • Grouped options are virtualized as rows; the group heading stays pinned while scrolling a windowed list.
  • Lists up to 200 rows mount every row; longer ones are windowed.
  • New menuFooter prop renders below the scroll area.
  • A custom components.Option is wrapped so it also skips the hover handlers.

Verification

  • yarn test: 175 suites, 1,993 tests pass.
  • Checked against cloud-frontend#6002 with yarn to-cloud; its four CI shards pass on this build.

- Theme: editor accent, modal backdrop and related tokens for both themes.
- Field surface: fieldSurface, fieldHalo, fieldHaloShadow and chevronMark
  mixins; appearance="surface" on Select and TextInput; selectSurfaceStyles
  exported for composed controls.
- Select: option hover is a CSS rule instead of react-select state, so
  pointing no longer re-renders the menu; grouped options are virtualized
  as rows with the group heading pinned while scrolling; lists up to 200
  rows mount fully; menuFooter renders below the scroll area.
- Vertical tabs: the selected tab uses body text on the segmented selected
  background with the primary left bar.
- Toggle, ButtonGroup and dropdown items take the Sage editor colours.
@novykh
novykh merged commit 79616c5 into master Nov 17, 2026
2 checks passed
@novykh
novykh deleted the feat/sage-editor-hierarchy branch November 17, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants