v5.5.13 - #645
Merged
Merged
v5.5.13#645
Conversation
kapantzak
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Chrome/Safari page translation replaces text nodes with
<font>elements. When React later inserts before, or removes, one of those text nodes, it throwsNotFoundErrorand the subtree crashes. Production Sentry traced this to@netdata/charts; the same pattern is being removed across charts and cloud-frontend.Changes
local/translation-safe-text(eslint/rules/translationSafeText.js) that flags conditional text rendered next to other children, e.g.{a ? "x" : ""}{b}or{cond && <X/>}text. The rule file is identical in charts and cloud-frontend.eslint/rules/translationSafeText.test.js);jest/config.jsroots includeeslint/. The test polyfillsstructuredClonebecause RuleTester needs it and the jsdom environment does not provide it.src.Note
The repo's ESLint setup does not load today:
eslint.config.jsimports@eslint/js, which is not a dependency, andeslint-plugin-react7.37.5 does not support ESLint 10 (context.getFilename is not a function). The rule is wired in and will run once that is fixed; it is not addressed in this PR.Testing
Full suite: 499/499 passing.