v5.5.12 - #644
Merged
Merged
v5.5.12#644
Conversation
The compact 40px header row was set as a fixed height, but the header cell stacks the label and the column filter in a column flex, so any column with a filter rendered its select outside the cell. Setting it as a minimum keeps label-only headers at 40px and lets the filtered ones grow to fit.
novykh
approved these changes
Sep 21, 2026
kapantzak
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Table columns that declare a header filter render the select outside the header cell, clipped from the bottom edge.
The compact 40px header row introduced in #641 was applied as a fixed height:
but the header cell stacks the label and the filter in a column flex, so a filtered column needs more than 40px and the select overflows.
Reproduced in
@netdata/cloud-frontendon the space settings nodes table, where theStatusandCommissionedcolumns are the two withmeta.filter.component: "select". It affects every filtered column in every consuming table, including the notifications channels table.Fix
A minimum rather than a fixed height. Label-only headers still render at exactly 40px, so the compact design from #641 is preserved; only cells that carry a filter grow.
Tests
Two regression tests in
cell.test.js, both confirmed to fail with the fix reverted:Full suite: 99 suites, 487 tests, 9 snapshots, all passing.