Skip to content

Update Nedi CDN libraries and bump the asset cache-buster to v=21 - #3210

Open
ktsaou wants to merge 2 commits into
masterfrom
nedi-cdn-mermaid-12.3.0-turndown-7.2.5
Open

ktsaou wants to merge 2 commits into
masterfrom
nedi-cdn-mermaid-12.3.0-turndown-7.2.5

Conversation

@ktsaou

@ktsaou ktsaou commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Summary

Updates the Nedi chat widget assets in one change:

  • Moves the Nedi chat widget's CDN libraries to the versions the ai-agent embed UI now uses:

    • mermaid 12.2.0 → 12.3.0
    • turndown 7.2.4 → 7.2.5

    URLs and SRI (SHA-384) values are updated. Nedi requires identical library URLs in ai-agent, Netdata Learn and Netdata Cloud Frontend; these changes restore that parity.

  • Bumps the cache-buster on the three Nedi assets (ai-agent-ui.css, ai-agent-public.js, ai-agent-ui.js) from v=20 to v=21, matching Netdata Cloud Frontend, so browsers fetch the current Nedi widget script. That script moves keyboard focus to the chat input after the Clear button is pressed and removes the undocumented homeContent option, which this integration never used. The widget constructor and global API are unchanged. (Previously Bump Nedi asset cache-buster to v=21 #3186.)

Merge timing

Merge after the Nedi deploy that serves the refocus-after-Clear script. Before it, v=21 would fetch and cache the old script under the new key for up to an hour.

Verification

  • The jsDelivr files are byte-identical to the files in the npm tarballs, the tarballs match their registry integrity values, and both publishers are unchanged (mermaid publishes with SLSA provenance).
  • turndown 7.2.5 only changes how output is accumulated internally. The mermaid 12.3.0 bundle adds no network, evaluation, storage or messaging calls.
  • In headless Chromium with SRI enforced, the Nedi renderer produced identical results with the old and new libraries: Mermaid diagrams, Graphviz, tables, links and Turndown GFM conversion.
  • yarn build passes on Node 22 with both changes.

Summary by CodeRabbit

  • Chores
    • Updated the bundled diagram-rendering and Markdown-conversion components to newer versions.
    • Refreshed the versions of the application’s endpoint styles and scripts.

@netlify

netlify Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for netdata-docusaurus ready!

Name Link
🔨 Latest commit 0fe369e
🔍 Latest deploy log https://app.netlify.com/projects/netdata-docusaurus/deploys/6afca0a4e71253f2fff73aab
😎 Deploy Preview https://deploy-preview-3210--netdata-docusaurus.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The NEDI asset declarations now use Mermaid 12.3.0 and Turndown 7.2.5 with updated integrity hashes. Endpoint CSS and JavaScript asset query versions change from v=20 to v=21.

Changes: NEDI asset updates

Layer / File(s) Summary
Asset versions and cache-buster keys
src/components/Nedi/assets.js
The Mermaid and Turndown asset URLs and integrity hashes are updated. Endpoint CSS and JavaScript asset query versions change from v=20 to v=21.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related PRs

  • netdata/learn#3186: This PR changes the same endpoint asset query versions from v=20 to v=21.

Suggested reviewers: witalisoft

Merge Risk: Minimal · up to 0fe36

This updates the Nedi chat widget's Mermaid and Turndown CDN libraries and bumps the asset cache keys. No actionable merge-blocking risk was found. Merge after the Nedi deploy that serves the v=21 script, as the author notes.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the two main changes: updating the Nedi CDN libraries and bumping the asset cache-buster to v=21. The raw summary confirms Mermaid 12.2.0 to 12.3.0, Turndown 7.2.4 to 7.2.5, and v=20 t…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the two main changes: updating the Nedi CDN libraries and bumping the asset cache-buster to v=21. The raw summary confirms Mermaid 12.2.0 to 12.3.0, Turndown 7.2.4 to 7.2.5, and v=20 to v=21 in NEDI_ASSETS. The title is concise, specific, and matches the changeset. It does not mention the widget script change, which the objectives describe as a further aspect of the PR, but that is expected for a short title.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3272d0e7-95f4-4327-a80f-6431eb0dbcea
Commits

Reviewing files that changed from the base of the PR and between a328f70 and 0fe369e.

Files selected for processing: 1

  • src/components/Nedi/assets.js

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@ktsaou ktsaou changed the title Update Nedi CDN libraries to mermaid 12.3.0 and turndown 7.2.5 Update Nedi CDN libraries and bump the asset cache-buster to v=21 Nov 17, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant