Skip to content

fix(commitment-lock): reject type script on CKB successor - #31

Merged
quake merged 2 commits into
nervosnetwork:mainfrom
quake:fix/ckb-successor-type-script
Oct 1, 2026
Merged

quake merged 2 commits into
nervosnetwork:mainfrom
quake:fix/ckb-successor-type-script

Conversation

@quake

@quake quake commented Sep 29, 2026

Copy link
Copy Markdown
Member

Summary

  • Reject CKB successor outputs with an unexpected type script using the existing OutputTypeError.
  • Add a CKB VM regression that signs a settlement creating a correctly locked and funded successor with an extra, valid type script; it must be rejected.

Verification

  • Regression fails before the contract change and passes after rebuilding the RISC-V contract.
  • cargo test (19 integration tests passed)
  • cargo fmt --all -- --check
  • cargo clippy --all-targets -- -D warnings

Note: the top-level targeted make build command builds and copies commitment-lock, then fails because it also attempts to build a non-existent commitment-lock-sim package. The rebuilt binary was used by the VM tests.

@quake
quake merged commit e7e1c9b into nervosnetwork:main Oct 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant