Repository navigation
feat(commitment-lock): support full payment hash settlement - #30
Merged
Merged
Conversation
…ent cells - v1 partial settlements previously produced 57-byte derived cells (legacy form), bricking the remaining v1 pending HTLCs; the output lock args now append args[57] when the input is a 58-byte v1 cell - restore the original combined OutputLockError check for the output lock script so legacy failure codes stay identical - add v1_derived_cell_resettlement_succeeds covering the two-step settlement flow; drop debug printlns; revert test capacity rewrite
quake
marked this pull request as ready for review
September 14, 2026 01:39
jjyr
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: add a feature-flagged v1 commitment-lock layout with a full 32-byte payment hash; preserve the legacy 57-byte args and 85-byte HTLC layout; propagate the feature flag through derived settlement cells; add prefix-only preimage rejection, cross-layout, and UDT regression tests. Verification: make build MODE=release; make test (12/12 passed); cargo fmt check; cargo clippy with warnings denied.