Skip to content

Add CI and lock script regressions - #29

Merged
quake merged 1 commit into
nervosnetwork:mainfrom
Xcodes-chain:codex/fiber-scripts-ci-regression
Sep 29, 2026
Merged

quake merged 1 commit into
nervosnetwork:mainfrom
Xcodes-chain:codex/fiber-scripts-ci-regression

Conversation

@Xcodes-chain

Copy link
Copy Markdown
Contributor

Summary

Adds a PR validation structure for Fiber scripts and expands contract regression coverage.

  • Adds fmt-check and pr-verify Makefile targets.
  • Extends CI to run format and clippy before reproducible build and tests.
  • Adds CI workflow guard tests so required PR validation layers are not accidentally removed.
  • Adds FundingLock negative regressions for multiple group inputs, malformed witness args, and wrong signatures.
  • Adds a CommitmentLock stale revocation version regression.
  • Updates scripts/find_clang to skip Apple clang, which reports a high version but cannot build the CKB RISC-V target.

Validation

  • cargo fmt --check
  • make clippy CARGO_ARGS="--all-targets"
  • cargo test -p tests ci_workflow
  • cargo test -p commitment-lock test_mul

Notes

make build could not be completed on the local macOS environment because it lacks non-Apple LLVM clang 16+ / RISC-V C compiler support and Docker. The CI workflow still runs the reproducible Docker build.

@Xcodes-chain
Xcodes-chain force-pushed the codex/fiber-scripts-ci-regression branch from b129c0c to b407021 Compare July 20, 2026 06:33
@Xcodes-chain
Xcodes-chain force-pushed the codex/fiber-scripts-ci-regression branch from b407021 to de40c30 Compare July 20, 2026 06:46
@Xcodes-chain
Xcodes-chain marked this pull request as ready for review July 20, 2026 07:13
@quake
quake merged commit 57285f3 into nervosnetwork:main Sep 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants