Skip to content

[codex] Document GameFi QA checklist#84

Open
Jim8y wants to merge 5 commits into
neoorder:masterfrom
Jim8y:codex/gamefi-qa-checklist
Open

[codex] Document GameFi QA checklist#84
Jim8y wants to merge 5 commits into
neoorder:masterfrom
Jim8y:codex/gamefi-qa-checklist

Conversation

@Jim8y

@Jim8y Jim8y commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add a GameFi QA checklist and performance gate for reviewing game dApps before listing or promotion.
  • Cover submission evidence, loading/failure states, mobile layout, performance thresholds, wallet integration, optional native capabilities, and platform test matrix.
  • Include a reviewer notes template and pass criteria that preserve existing Erik/admin guardrails.

Scope

Part of #76, Task 8: Game QA Checklist and Performance Gate.

This is documentation only. It does not add runtime diagnostics export, runtime blocking, local transaction storage, permission-center behavior, trust bar UI, or third-party game DOM/CSS adaptation.

Validation

  • git diff --check
  • dotnet build OneGateApp/OneGateApp.csproj -f net10.0-ios -c Debug -p:RuntimeIdentifier=iossimulator-arm64 -p:CodesignKey=- -p:CodesignProvision= -p:ProvisioningType=automatic --nologo
  • dotnet build OneGateApp/OneGateApp.csproj -f net10.0-android -c Debug -p:EmbedAssembliesIntoApk=true --nologo
  • iOS simulator install/launch/screenshot on OneGate-PR51-iPhone17.
  • Android emulator install/launch/screenshot on emulator-5554; MainActivity resumed.

Notes

Build warnings are existing repository/environment warnings: SQLitePCLRaw NU1903 advisories, iOS duplicate ImageAsset warnings, and the local Android JDK path validation warning.

Copilot AI review requested due to automatic review settings July 2, 2026 04:40
@Jim8y

Jim8y commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Validation screenshots and notes for this PR:

  • Android emulator: installed Debug APK on emulator-5554, launched org.neoorder.onegate/crc64e93af8ff8666345c.MainActivity, and confirmed MainActivity is resumed.
  • iOS simulator: installed and launched on OneGate-PR51-iPhone17.
  • Screenshot assets are uploaded to GitHub release assets, not committed to the repository.

Android launch

iOS launch

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an internal documentation checklist to standardize GameFi/game dApp QA reviews prior to listing/promotion, with an explicit performance gate and reviewer evidence requirements aligned with existing guardrails (no committed QA artifacts, no OneGate-side DOM/CSS patching, etc.).

Changes:

  • Introduces a GameFi QA checklist covering submission evidence, loading/failure states, mobile layout, wallet integration, and optional native capabilities.
  • Defines a performance gate table (timings/long-frame rate/memory/assets) plus pass criteria for listing/promotion decisions.
  • Provides a reviewer notes template and a platform test matrix for consistent cross-platform validation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/gamefi-qa-checklist.md Outdated
Comment thread docs/gamefi-qa-checklist.md Outdated
@Jim8y

Jim8y commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Review follow-up pushed in 2375b74.

Addressed:

  • Performance gate now labels PSS as Android-only.
  • Pass criteria now says performance metrics instead of implying memory is defined identically on both platforms.

Validation:

  • Documentation-only change; git diff --check passed.

@erikzhang erikzhang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not include unaccepted APIs in the documentation.

@Jim8y

Jim8y commented Jul 4, 2026

Copy link
Copy Markdown
Contributor Author

Addressed Erik's review request.

Changes:

  • Removed the optional native capability list from the QA checklist.
  • Replaced it with guidance that proposed/unaccepted OneGate APIs must not be required, documented, or tested as listing criteria.
  • Updated the reviewer template and pass criteria to record unaccepted API needs as separate proposals instead of treating them as QA requirements.

Validation: docs-only change; git diff --check passed.

Comment thread docs/gamefi-qa-checklist.md Outdated
@Jim8y

Jim8y commented Jul 5, 2026

Copy link
Copy Markdown
Contributor Author

Addressed Erik's review feedback in b22d9bc.

Change:

  • Removed the onegate-game.json preflight requirement from the GameFi QA checklist.
  • Removed the optional manifest URL from required review evidence.

Validation:

  • Confirmed the document no longer references onegate-game.json.
  • git diff --check passed.

This is a documentation-only PR, so no simulator screenshot was captured for this update.

@Jim8y

Jim8y commented Jul 5, 2026

Copy link
Copy Markdown
Contributor Author

Current head already addresses the open documentation feedback.

Checked in this pass:

  • No remaining onegate-game.json reference; the checklist now uses generic metadata/submission wording instead of inventing a new manifest file.
  • Android memory metric is explicitly labeled Android-only PSS.
  • Pass criteria uses performance metrics wording instead of implying a cross-platform memory threshold.

No additional commit was needed in this pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants