Improve dApp detail page#55
Conversation
|
iOS and Android simulator verification screenshots:
Verification:
Review follow-up:
|
There was a problem hiding this comment.
Pull request overview
Improves the existing dApp detail page UI by adding clearer provenance and contextual metadata (source info, catalog/external status, website host, runtime permission explanation, recent-open state, and localized tags) while preserving existing actions/flows (open, favorite, add-to-home, share, screenshots, description, languages).
Changes:
- Added new localized string resources for dApp source/status, permissions summary, recent activity, and tags (EN + zh-Hans).
- Extended
DAppDetailsPagecode-behind with computed display properties (hosts/status/tags/recent state) derived from the boundDAppand local settings. - Refactored
DAppDetailsPageXAML layout to present the new metadata in “Card” sections while keeping existing content sections.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| OneGateApp/Properties/Strings.zh-Hans.resx | Adds zh-Hans translations for new dApp detail metadata labels and helper text. |
| OneGateApp/Properties/Strings.resx | Adds English strings for new dApp detail metadata labels and helper text. |
| OneGateApp/Properties/Strings.Designer.cs | Regenerates strongly-typed resource accessors for the new string keys. |
| OneGateApp/Pages/DAppDetailsPage.xaml.cs | Computes source/website hosts, catalog vs external status, recent-open text, and localized tag display for binding. |
| OneGateApp/Pages/DAppDetailsPage.xaml | Updates the dApp details UI to render the new source/permissions/recent activity/tags sections in Card layouts. |
Files not reviewed (1)
- OneGateApp/Properties/Strings.Designer.cs: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Addressed Erik's review request in . Changes:
Validation:
若要显示开关的语法,请键入“MSBuild -help”.
No screenshots were committed to the repository. |
|
Addressed Erik's review request in Changes:
Validation:
No screenshots were committed to the repository. |
# Conflicts: # OneGateApp/Pages/DAppDetailsPage.xaml.cs
|
Resolved the latest master merge conflict on this PR. What changed in the merge resolution:
Validation:
Screenshots were captured locally under |
|
Addressed Erik's review feedback in Change:
Validation:
Existing SQLitePCLRaw |
|
Current head already addresses the open third-party dApp feedback. Checked in this pass:
No additional commit was needed in this pass. |
Scope
Validation
git diff --checkScreenshots
Known limitations
dapps/recentlist, so it only indicates whether the app was recently opened on this device.