Add Activity Center#53
Conversation
|
iOS and Android simulator verification screenshots:
Verification:
Review follow-up:
|
d538bb3 to
3ca4483
Compare
|
What is VaultOperation? |
There was a problem hiding this comment.
Pull request overview
Adds a new Settings subpage (“Activity Center”) that records and displays recent on-device wallet/dApp actions (connections, authorizations, signatures, submitted transactions, and Vault operations) using the existing Settings key/value store.
Changes:
- Introduces a local activity timeline model + persistence service (capped to the latest 50 records).
- Adds a new Activity Center page (UI + summary counters) and wires it into Shell routing and Settings.
- Hooks activity recording into dApp launch, wallet authorization, signing, and transaction relay flows.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| OneGateApp/Services/ActivityLogService.cs | Persists and retrieves capped activity records from Settings storage. |
| OneGateApp/Models/ActivityRecord.cs | Defines activity record model + kind enum. |
| OneGateApp/Pages/ActivityCenterPage.xaml.cs | Loads recent records into view-model items for display and summary counts. |
| OneGateApp/Pages/ActivityCenterPage.xaml | New Settings subpage UI for activity timeline + counters + empty state. |
| OneGateApp/Pages/SettingsPage.xaml.cs | Adds Activity Center entry and summary text (“No recent activity” / “{n} records”). |
| OneGateApp/Pages/LaunchDAppPage.xaml.cs | Records dApp connections when launching/opening a dApp. |
| OneGateApp/Pages/LaunchDAppPage.xaml.dAPI.cs | Records wallet authorization, signing, and transaction submission events. |
| OneGateApp/MauiProgram.cs | Registers ActivityLogService in DI. |
| OneGateApp/AppShell.xaml.cs | Registers new route for home/settings/activity. |
| OneGateApp/Properties/Strings.resx | Adds EN strings for Activity Center UI and activity record text. |
| OneGateApp/Properties/Strings.zh-Hans.resx | Adds zh-Hans strings for Activity Center UI and activity record text. |
| OneGateApp/Properties/Strings.Designer.cs | Regenerates strongly-typed accessors for new resource keys. |
Files not reviewed (1)
- OneGateApp/Properties/Strings.Designer.cs: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@erikzhang addressed the naming: |
|
Latest review follow-up after merging current master (bb40f15): the outdated Copilot concern is already addressed by Review handling:
Validation:
Refreshed screenshots: Screenshots are GitHub release assets only and are not committed to the repository. Ready for re-review. |
|
Conflicts |
|
Review follow-up for Erik's
Validation after rebasing on the latest PR branch:
Screenshots are external GitHub release assets only; none are committed to the repo. |
…enter # Conflicts: # OneGateApp/Properties/Strings.de.resx # OneGateApp/Properties/Strings.es.resx # OneGateApp/Properties/Strings.fr.resx # OneGateApp/Properties/Strings.id.resx # OneGateApp/Properties/Strings.it.resx # OneGateApp/Properties/Strings.ja.resx # OneGateApp/Properties/Strings.ko.resx # OneGateApp/Properties/Strings.nl.resx # OneGateApp/Properties/Strings.pt-BR.resx # OneGateApp/Properties/Strings.ru.resx # OneGateApp/Properties/Strings.tr.resx # OneGateApp/Properties/Strings.vi.resx # OneGateApp/Properties/Strings.zh-Hant.resx
|
Update after latest review follow-up:
Validation on latest branch head
Existing simulator screenshots for the Vault-category removal verification remain available here:
Notes: builds still report the existing |
…enter # Conflicts: # OneGateApp/Properties/Strings.de.resx # OneGateApp/Properties/Strings.es.resx # OneGateApp/Properties/Strings.fr.resx # OneGateApp/Properties/Strings.id.resx # OneGateApp/Properties/Strings.it.resx # OneGateApp/Properties/Strings.ja.resx # OneGateApp/Properties/Strings.ko.resx # OneGateApp/Properties/Strings.nl.resx # OneGateApp/Properties/Strings.pt-BR.resx # OneGateApp/Properties/Strings.resx # OneGateApp/Properties/Strings.ru.resx # OneGateApp/Properties/Strings.tr.resx # OneGateApp/Properties/Strings.vi.resx # OneGateApp/Properties/Strings.zh-Hans.resx # OneGateApp/Properties/Strings.zh-Hant.resx
|
Addressed the storage review feedback. Changes pushed:
Validation:
Notes:
|
Scope
Validation
git diff --checkStrings*.resxfiles: 324 keys eachnet10.0-android,android-arm64net10.0-ios,iossimulator-arm64Screenshots
Latest verification screenshots are posted in PR comments as external GitHub assets; screenshots are not committed to the repository.
Review follow-up
ActivityLogService.GetRecentAsync()catches corrupt/incompatible local Settings data and returns an empty list instead of crashing Settings/Activity Center.VaultOperation/OneGateVaultTransactionconcept entirely instead of renaming it.Transactionactivity.Known limitations