Skip to content

fix: map text-align start/end to left/right #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abdalkaderdev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: map text-align start/end to left/right #471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/__tests__/vendor/tailwind/typography.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,16 @@ describe("Typography - Text Align", () => {
props: { style: { textAlign: "justify" } },
});
});
test("text-start", async () => {
expect(await renderCurrentTest()).toStrictEqual({
props: { style: { textAlign: "left" } },
});
});
test("text-end", async () => {
expect(await renderCurrentTest()).toStrictEqual({
props: { style: { textAlign: "right" } },
});
});
});

describe("Typography - Text Color", () => {
Expand Down
10 changes: 10 additions & 0 deletions src/compiler/declarations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2446,6 +2446,16 @@ export function parseTextAlign(
{ value }: DeclarationType<"text-align">,
builder: StylesheetBuilder,
) {
// React Native has no logical `start`/`end` for textAlign. On <Text> it
// resolves `left`/`right` against the writing direction, so they already
// behave as the logical values and the mapping can happen at compile time.
// <TextInput> treats them as physical: facebook/react-native#45255
if (value === "start") {
return "left";
} else if (value === "end") {
return "right";
}

const allowed = new Set(["auto", "left", "right", "center", "justify"]);
if (allowed.has(value)) {
return value;
Expand Down