Skip to content

CMR-11371: Fix db-migrate for coll alias and historical revisions - #2470

Merged
jmaeng72 merged 7 commits into
masterfrom
CMR-11371
Jul 22, 2026
Merged

CMR-11371: Fix db-migrate for coll alias and historical revisions#2470
jmaeng72 merged 7 commits into
masterfrom
CMR-11371

Conversation

@jmaeng72

Copy link
Copy Markdown
Contributor

Overview

What is the objective?

Fix db-migrate to not rely on hardcoded coll index when setting up coll alias during an index-set update

What are the changes?

  • coll index is now based on canonical name rather than index name
  • add sys int tests
  • update db-migrate and update-indexes to both get and use the correct revision-id and concepts keyword to save properly in the db for historical references to index-set

What areas of the application does this impact?

Indexer

Required Checklist

  • New and existing unit and int tests pass locally and remotely
  • clj-kondo has been run locally and all errors in changed files are corrected
  • I have commented my code, particularly in hard-to-understand areas
  • I have made changes to the documentation (if necessary)
  • My changes generate no new warnings

Additional Checklist

  • I have removed unnecessary/dead code and imports in files I have changed
  • I have cleaned up integration tests by doing one or more of the following:
    • migrated any are2 tests to are3 in files I have changed
    • de-duped, consolidated, removed dead int tests
    • transformed applicable int tests into unit tests
    • reduced number of system state resets by updating fixtures. Ex) (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

@codecov-commenter

codecov-commenter commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 45.83333% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.92%. Comparing base (d84702b) to head (cb64496).

Files with missing lines Patch % Lines
indexer-app/src/cmr/indexer/data/elasticsearch.clj 15.62% 27 Missing ⚠️
...tils-lib/src/cmr/elastic_utils/es_index_helper.clj 16.66% 5 Missing ⚠️
indexer-app/src/cmr/indexer/data/index_set.clj 40.00% 3 Missing ⚠️
...app/src/cmr/indexer/services/index_set_service.clj 33.33% 2 Missing ⚠️
...tic-utils-lib/src/cmr/elastic_utils/index_util.clj 50.00% 1 Missing ⚠️
...-test/src/cmr/system_int_test/utils/index_util.clj 95.45% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2470      +/-   ##
==========================================
+ Coverage   57.91%   57.92%   +0.01%     
==========================================
  Files        1073     1073              
  Lines       74623    74651      +28     
  Branches     2167     2173       +6     
==========================================
+ Hits        43219    43245      +26     
+ Misses      29378    29374       -4     
- Partials     2026     2032       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmaeng72
jmaeng72 merged commit ca9c018 into master Jul 22, 2026
6 checks passed
@jmaeng72
jmaeng72 deleted the CMR-11371 branch July 22, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants