Skip to content

CMR-11364: Fix intermittent fail of int test on CICD#2464

Draft
zimzoom wants to merge 3 commits into
masterfrom
CMR-11364-b
Draft

CMR-11364: Fix intermittent fail of int test on CICD#2464
zimzoom wants to merge 3 commits into
masterfrom
CMR-11364-b

Conversation

@zimzoom

@zimzoom zimzoom commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Overview

What is the objective?

Fix bug where collection-shapefile-force-cartesian-validation-test was failing intermittently, getting a 404 instead of successful search response.

What are the changes?

This test was failing due to timing issues that pop up on the CICD server. It used side/eval-form to enable the shapefile flag via async HTTP, then immediately made search requests before the flag was actually set in the running system. Added retry logic with wait-for-shapefile-flag-enabled to verify the flag is enabled before proceeding, and retry-search-until-success to handle timing issues during shapefile processing itself.

Error messages were also enhanced to display actual validation errors instead of lazy sequence references for easier debugging.

What areas of the application does this impact?

system-int-test

Required Checklist

  • New and existing unit and int tests pass locally and remotely
  • clj-kondo has been run locally and all errors in changed files are corrected
  • I have commented my code, particularly in hard-to-understand areas
  • I have made changes to the documentation (if necessary)
  • My changes generate no new warnings

Additional Checklist

  • I have removed unnecessary/dead code and imports in files I have changed
  • I have cleaned up integration tests by doing one or more of the following:
    • migrated any are2 tests to are3 in files I have changed
    • de-duped, consolidated, removed dead int tests
    • transformed applicable int tests into unit tests
    • reduced number of system state resets by updating fixtures. Ex) (use-fixtures :each (ingest/reset-fixture {})) to be :once instead of :each

@zimzoom zimzoom changed the title Cmr 11364 b CMR-11364: Fix intermittent fail of int test on CICD Jul 15, 2026
@zimzoom
zimzoom marked this pull request as draft July 16, 2026 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants