Optimise hosted instances page#2199
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Warning Review limit reached
More reviews will be available in 55 minutes and 7 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAdds an ENSv2 transition callout component and updates HostedEnsNodeInstance to show service icons; wires the new callout and icon fragments across hosted-instances.mdx and removes inline ENSv2 NOTE text from shared compatibility strings. ChangesENSv2 Transition Messaging and Documentation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR optimises the hosted instances documentation page by introducing a new
Confidence Score: 5/5Safe to merge; all changes are documentation and static UI components with no runtime logic. The new component is correctly wired at every call site — The Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
MDX["hosted-instances.mdx"]
HEI["HostedEnsNodeInstance.astro\n(table layout + icon slots)"]
ESC["EnsSubgraphCorrectnessPostEnsV2Launch.astro\n(danger callout)"]
MDX -->|"instanceURL, namespace, plugins props\n+ icon/content slots"| HEI
MDX -->|"namespace + isEnsV2Launched props"| ESC
ESC -->|"isEnsV2Launched = true"| LAUNCHED["ENSv2 launched message\n(sepolia-v2)"]
ESC -->|"isEnsV2Launched = false"| NOTYET["ENSv2 coming soon message\n(mainnet, sepolia)"]
HEI --> SLOTS["Rendered slot rows:\n• ENS Omnigraph API [icon]\n• ENS Protocol Acceleration [icon]\n• ENS Subgraph API [icon + callout]"]
Reviews (5): Last reviewed commit: "Apply AI PR feedback" | Re-trigger Greptile |
There was a problem hiding this comment.
Pull request overview
This PR refines the “Hosted ENSNode Instances” documentation page by improving the presentation of service availability and extracting the ENS Subgraph post-ENSv2 warning into a reusable component.
Changes:
- Adds explicit ✅/❌ indicators for Omnigraph / Subgraph / Protocol Acceleration per hosted instance.
- Extracts the “ENS Subgraph correctness after ENSv2 launch” warning into a dedicated Astro molecule for reuse/consistency.
- Improves the
ens-test-envnamespace bullet by moving long details into a:::noteblock.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/ensnode.io/src/content/docs/docs/hosted-instances.mdx | Updates hosted instances content, adds service icons, and inserts the extracted warning component. |
| docs/ensnode.io/src/components/molecules/HostedEnsNodeInstance.astro | Adds new icon slots and renames the “ENS APIs” table label to “ENSApi Services”. |
| docs/ensnode.io/src/components/molecules/EnsSubgraphCorrectnessPostEnsV2Launch.astro | Introduces a reusable Starlight Aside warning about Subgraph correctness post-ENSv2. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
@greptile review |
lightwalker-eth
left a comment
lightwalker-eth
left a comment
There was a problem hiding this comment.
@tk-o Thanks for updates. Reviewed and shared feedback. Please take the lead to merge when ready 👍
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
♻️ Duplicate comments (1)
docs/ensnode.io/src/content/docs/docs/hosted-instances.mdx (1)
77-81:⚠️ Potential issue | 🟠 Major | ⚡ Quick winPass
namespaceinto every ENSv2 callout usage.
EnsSubgraphCorrectnessPostEnsV2Launchnow interpolatesnamespace, but these callsites omit it, so the rendered warning text will includeundefined ENS namespace.💡 Proposed fix
- <EnsSubgraphCorrectnessPostEnsV2Launch isEnsV2Launched={true} /> + <EnsSubgraphCorrectnessPostEnsV2Launch isEnsV2Launched={true} namespace="sepolia-v2" /> @@ - <EnsSubgraphCorrectnessPostEnsV2Launch /> + <EnsSubgraphCorrectnessPostEnsV2Launch namespace="mainnet" /> @@ - <EnsSubgraphCorrectnessPostEnsV2Launch /> + <EnsSubgraphCorrectnessPostEnsV2Launch namespace="sepolia" /> @@ - <EnsSubgraphCorrectnessPostEnsV2Launch /> + <EnsSubgraphCorrectnessPostEnsV2Launch namespace="mainnet" /> @@ - <EnsSubgraphCorrectnessPostEnsV2Launch /> + <EnsSubgraphCorrectnessPostEnsV2Launch namespace="sepolia" />Also applies to: 107-111, 129-133, 155-159, 177-181
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/ensnode.io/src/content/docs/docs/hosted-instances.mdx` around lines 77 - 81, Pass the missing namespace prop into every usage of the EnsSubgraphCorrectnessPostEnsV2Launch component (e.g., the call currently written as <EnsSubgraphCorrectnessPostEnsV2Launch isEnsV2Launched={true} />) so it receives a valid namespace string (for example: <EnsSubgraphCorrectnessPostEnsV2Launch isEnsV2Launched={true} namespace={subgraphNamespace} />); update each callsite noted (around the other Fragment blocks) to supply the same namespace variable or prop that the surrounding component/page uses so the component no longer renders "undefined ENS namespace".
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In `@docs/ensnode.io/src/content/docs/docs/hosted-instances.mdx`:
- Around line 77-81: Pass the missing namespace prop into every usage of the
EnsSubgraphCorrectnessPostEnsV2Launch component (e.g., the call currently
written as <EnsSubgraphCorrectnessPostEnsV2Launch isEnsV2Launched={true} />) so
it receives a valid namespace string (for example:
<EnsSubgraphCorrectnessPostEnsV2Launch isEnsV2Launched={true}
namespace={subgraphNamespace} />); update each callsite noted (around the other
Fragment blocks) to supply the same namespace variable or prop that the
surrounding component/page uses so the component no longer renders "undefined
ENS namespace".
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 627f0fb5-c22b-4d16-b92b-c3566056a96d
📒 Files selected for processing (2)
docs/ensnode.io/src/components/molecules/EnsSubgraphCorrectnessPostEnsV2Launch.astrodocs/ensnode.io/src/content/docs/docs/hosted-instances.mdx
| ? "ENSv2 launch completed. Subgraph API now unreliable." | ||
| : "ENSv2 launches soon. Subgraph API soon unreliable."; |
This PR addresses the "Quick Feedback" (point 1. to 5.) section the doc discussed in this thread.