Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The anthracene/cc-pVDZ calculation repeatedly jumped by about 180 hartree while the SCF residual stayed near 40. RHF now rejects DIIS proposals that increase the energy beyond roundoff, clears the history, and minimizes the exact quadratic RHF energy along a fresh physical density step. Mixed intermediate densities cannot satisfy the convergence check; final orbitals still pass canonicalization before MP2.
DIIS also retries shorter histories when the solve is singular, nonfinite, or requires excessively large cancelling weights. The PR includes the anthracene geometry and its cc-pVDZ calculation.toml with 300 iterations, a 1e-8 threshold, six DIIS vectors, and MP2. The temporary scf-check.toml has been removed locally and is not included.
Validation:
cargo test -p rustiq-core --no-default-features: 160 unit tests, 18 integration tests, and 4 documentation tests passed.cargo clippy -p rustiq-core --all-targets --no-default-features -- -D warningscargo fmt --all -- --checkThe full anthracene calculation was not rerun at the user's request. Its convergence with this correction remains unverified.