Optimize command handling and add support for command aliases - #5277
Open
MohabCodeX wants to merge 2 commits into
Open
Optimize command handling and add support for command aliases#5277MohabCodeX wants to merge 2 commits into
MohabCodeX wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is split into two commits / parts:
Part 1: Command Handling Refactor & Performance Optimization
new/delete) on every command execution by using a fast stack-allocated buffer on both client and server, removing unnecessary heap churn.ArgumentParserand cleaned up Hungarian notation across the command manager.Part 2: Command Aliases Support
Scripters often struggle when trying to assign or remove multiple aliases for the same command in a single line. For example, they currently have to write:
Now, they can simply do:
And similarly for removing them:
So... why not? It's a very useful QoL feature. While workarounds exist using Lua wrapper loops, having native core support is much cleaner, faster, and standardizes the workflow.
Everything is backward compatible with single string commands.
API Changes
addCommandHandlerremoveCommandHandlerTesting
An automated test resource test_command_aliases.zip was created to verify all changes:
/sv_test,/sv_alias,/sv_hello/cl_test,/cl_alias,/cl_hello