W-24105067: Document 25-character egress rule group name limit - #495
Open
kevintroller wants to merge 1 commit into
Open
kevintroller wants to merge 1 commit into
kevintroller wants to merge 1 commit into
Conversation
W-23579934 enforces a 25-character Name field with letters, numbers, and hyphens only. Replace the stale combined private-space-plus-rule-group 53-character rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ps-config-app-level-egress.adoc.<private_space_name>-<rule_group_name>≤ 53 characters) with the standalone 25-character Name limit and letters/numbers/hyphens only.Requested change vs. what landed
^[a-zA-Z0-9-]+$(letters, numbers, hyphens)<private_space_name>-<rule_group_name>≤ 53 characters)Style applied
Active voice, contractions, and no
the following. The regex is described as “letters, numbers, and hyphens” to match surrounding CX style.Sources
Open decisions for review
Test plan
ps-config-app-level-egress.adocand confirm the Create Rule Group step no longer mentions 53 characters.