fix(xsysinfo): avoid startup hang on intel_gpu_top - #12206
Open
leilei3167 wants to merge 1 commit into
Open
leilei3167 wants to merge 1 commit into
leilei3167 wants to merge 1 commit into
Conversation
Use -n 1 for a single JSON sample instead of -s 1, which sets a 1 ms refresh period and runs until interrupted on current intel_gpu_top. Fixes mudler#12205 Signed-off-by: leilei3167 <imleilei123@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #12205
Startup could hang when
intel_gpu_topis installed: we invokedintel_gpu_top -J -s 1, but on currentintel_gpu_topthe-sflag is the refresh period in milliseconds and the default run count is infinite. That left the process sampling every 1 ms until killed.Use
-n 1for a single JSON sample and cap the subprocess with a 10s timeout so a stuck tool cannot block LocalAI boot.Notes for Reviewers
getIntelGPUTopstill returns nil when memory stats are unavailable; this only fixes the blocking call during vendor probing.intelGPUTopArgsinpkg/xsysinfo/intel_gputop_internal_test.go.Verify
Old red / new green (same spec): with
-s 1still wired,intelGPUTopArgsspec fails; with-n 1,go test ./pkg/xsysinfo/passes.Signed commits