fix(reasoning): keep preclosed Gemma streams in content - #11148
Open
localai-org-maint-bot wants to merge 2 commits into
Open
fix(reasoning): keep preclosed Gemma streams in content#11148localai-org-maint-bot wants to merge 2 commits into
localai-org-maint-bot wants to merge 2 commits into
Conversation
Owner
|
@localai-org-maint-bot also update the gallery items of gemma to not use inline templates but should use tokenizer templates like others |
localai-org-maint-bot
force-pushed
the
bot/issue-11135-preclosed-reasoning
branch
from
July 27, 2026 21:03
2ad7cba to
dcfc88f
Compare
Collaborator
Author
|
Updated in f98f4fe: gallery/gemma.yaml now uses the GGUF tokenizer template instead of shared inline chat templates. The uncached core/gallery suite passes. |
Do not seed streaming reasoning state when the latest prompt thinking marker is already followed by its matching closing marker. This keeps direct Gemma 4 output in content when its template disables thinking with a preclosed channel. Assisted-by: Codex:gpt-5
Let the model-provided tokenizer template format Gemma conversations instead of maintaining a shared inline prompt template. Assisted-by: Codex:gpt-5
localai-org-maint-bot
force-pushed
the
bot/issue-11135-preclosed-reasoning
branch
from
July 27, 2026 22:01
f98f4fe to
d854322
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11135
Testing
go test -count=1 ./pkg/reasoning ./core/http/endpoints/openai ./core/http/endpoints/openresponsesgo test -count=1 -race ./pkg/reasoninggo vet ./pkg/reasoninggit diff --check origin/master...HEADDocumentation
No documentation change: this restores streaming output classification to match the existing non-streaming behavior.