Dependency Updates - #1133
Merged
Merged
Conversation
Update eslint, stylelint, webpack-cli, jasmine, and sinon to latest majors Bumps eslint, stylelint, stylelint-config-standard-scss, webpack-cli, copy-webpack-plugin, css-minimizer-webpack-plugin, jasmine-core, jasmine-browser-runner, and sinon. - Add @eslint/js and globals as explicit devDependencies, since eslint 10 no longer bundles them transitively. - Remove now-invalid /* eslint-env */ comments from webpack configs; flat config already supplies those globals. - Suppress stylelint's new block-no-redundant-nested-style-rules on three intentional cascade-order overrides (footer, forms, forms/index); flatten the same redundant nesting in the bidi mixin where no ordering is needed. - Modernize deprecated word-wrap/clip properties to overflow-wrap/clip-path (menu-item, visually-hidden mixin) — breaking for legacy IE, noted in CHANGELOG. Deferred: @babel/core, @babel/preset-env, and sass-loader majors are blocked by Node version floors (22.18+/24.11+/22.11+) above this repo's Node 20 target. sass 1.91->1.104 deferred.
knowler
approved these changes
Sep 9, 2026
stephaniehobson
added a commit
that referenced
this pull request
Sep 10, 2026
…ext-align, stale dependabot ignore Copilot flagged a real bug: this branch had replaced the original bidi() call's (right, 0, auto) tuple with a plain float: inline-end, but the dismiss button has position: absolute, which makes float a no-op. In LTR that left the button with no horizontal anchor at all (right: 0 was simply gone; left: auto did nothing either). Fixed by restoring the full anchor as a single logical property: inset-inline-end: 0, which replaces both the removed LTR value and the separate [dir=rtl] override block that used to provide it. While in that file, found and removed a second instance of the exact same dead-code pattern in the @media #{$mq-sm} block one screen down -- also float: inline-end on an element that inherits position: absolute from its parent rule. Confirmed via a before/after compile diff that removing it changes nothing in the rendered output (it was already fully ineffective); traced it back to the *original* main branch, which already had both a bidi() float tuple and a redundant plain float: right sitting next to each other, predating this PR entirely -- not a regression introduced here, just an existing bug this PR's translation preserved faithfully. knowler asked whether base/elements/_tables.scss's stray text-align: left (sitting right next to the new text-align: start) was intentional as a progressive-enhancement fallback. It wasn't -- git blame shows it predates the bidi() removal by years, and text-align: start has been supported in every browser for over a decade regardless of the new v23 matrix. Removed the dead duplicate. knowler also asked about two _footer.scss spots (a plain declaration after three @includes, and a bidi() call before a plain text-align). Checked both with a direct sass --verbose compile: zero mixed-decls warnings originate from _footer.scss at all currently, so no reordering is needed in either place -- confirming knowler's own "probably good to dismiss" read on the second one, and extending the same answer to the first. Removed the stale `ignore: sass` entry from .github/dependabot.yml, per Copilot's flag. It referenced #982 ("remove Sass variable fallbacks") as the blocker, but #1084 (the v23 tracking issue this PR is part of) explicitly notes that goal isn't required for v23, and this PR's whole point is un-pinning sass -- leaving the Dependabot ignore in place would have silently defeated that by preventing any future automated version-bump PRs from ever being opened. Not bumping the installed version myself here: update-deps (#1133, already merged) explicitly deferred a sass 1.91->1.104 bump as a separate, deliberate call ("without a blocker"), so a future Dependabot PR against the now-unblocked ignore rule is the right vehicle for that, not this fix. Verified: npm run lint, npm test (47 specs, Firefox + Chrome), and a before/after sass compile diff for both changed .scss files (confirmed byte-identical computed output for the tables fix, and the intended LTR/RTL behavior restored for the notification-bar fix, matching what the true pre-mixed-decls main branch produced).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update eslint, stylelint, webpack-cli, jasmine, and sinon to latest majors
Bumps eslint, stylelint, stylelint-config-standard-scss, webpack-cli, copy-webpack-plugin, css-minimizer-webpack-plugin, jasmine-core, jasmine-browser-runner, and sinon.
Deferred: @babel/core, @babel/preset-env, and sass-loader majors are blocked by Node version floors (22.18+/24.11+/22.11+) above this repo's Node 20 target. sass 1.91->1.104 deferred.
I have documented this change in the design system.CHANGELOG.md.Issue
n/a
Testing
Enter helpful notes for whoever code reviews this change.
I did a diff on the generated CSS files and fixed errors found that way.
I also ran visual comparison tests comparing this branch to main and found 0 visual regressions.