Scraper downloads and stores favicon in GCP bucket#34
Open
niklasbaumgardner wants to merge 6 commits into
Open
Scraper downloads and stores favicon in GCP bucket#34niklasbaumgardner wants to merge 6 commits into
niklasbaumgardner wants to merge 6 commits into
Conversation
niklasbaumgardner
requested review from
fterdal,
jaredhirsch and
nathan-barrett
and removed request for
jaredhirsch and
nathan-barrett
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added some setup so that it is hopefully easier to test this locally.
To connect to the GCP project and bucket that I've created,
gcloudneeds to be installed and authenticated.There are more detailed steps in the readme.
I've have invited everyone to be owners of the project so hopefully getting authenticated isn't too difficult.