Propagate finalize_run status fetch failures - #6693
Open
suhaibmujahid wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR changes the Eventarc-triggered run finalization path to stop swallowing Cloud Run execution status fetch failures, so transient upstream errors result in a 5xx response and Pub/Sub/Eventarc can retry instead of leaving runs unfinalized.
Changes:
- Remove the broad
try/except Exceptioninfinalize_runaroundjobs.get_execution_status(...)so exceptions propagate to the HTTP layer. - Ensure transient Cloud Run API failures can trigger delivery retries rather than returning 204 and silently bailing out.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Remove the broad exception swallow around in `finalize_run`. This ensures the route returns 5xx on transient errors so Pub/Sub/Eventarc retries, instead of silently leaving runs unfinalized with pending actions.
suhaibmujahid
force-pushed
the
worktree-fix-6691-finalize-run-raise
branch
from
August 22, 2026 02:32
94339cc to
60f4b58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6691
Remove the broad exception swallow around in
finalize_run. This ensures the route returns 5xx on transient errors so Pub/Sub/Eventarc retries, instead of silently leaving runs unfinalized with pending actions.