Remove run-mode note from bug-fix prompt#5991
Open
suhaibmujahid wants to merge 1 commit intomozilla:masterfrom
Open
Remove run-mode note from bug-fix prompt#5991suhaibmujahid wants to merge 1 commit intomozilla:masterfrom
suhaibmujahid wants to merge 1 commit intomozilla:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Removes the “run mode” guidance from the bug-fix agent’s system prompt so dry-run executions no longer include a mode-specific note.
Changes:
- Removed the
{run_mode_note}section fromprompts/system.md. - Simplified
load_system_prompt()to stop generating/injecting a dry-run vs live mode note.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| bugbug/tools/bug_fix/prompts/system.md | Removes the run-mode block from the agent system prompt template. |
| bugbug/tools/bug_fix/agent.py | Removes the code that formats and passes the run-mode note into the system prompt. |
Comments suppressed due to low confidence (1)
bugbug/tools/bug_fix/prompts/system.md:87
- Removing the run-mode section means the system prompt no longer tells the agent what to do differently in dry-run runs. Given the rest of the prompt still instructs the agent to call
update_bug/add_commentwhen confident, this will cause avoidable tool failures when running with dry-run restrictions. Consider adding a short, behavior-focused dry-run note somewhere (or ensure dry-run runs keep write tools callable but simulated) so the prompt matches the actual tool availability.
Always be **brief** and to the point. Do not post long-winded comments, developers have limited time to find the necessary information.
Do **not** post private comments, all developers on the bug need to see the comments.
# Additional instructions for this run
{extra_instructions}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
116
to
118
| return tmpl.format( | ||
| rules_dir=str(rules_dir.resolve()), | ||
| extra_instructions=extra or "(none)", |
Comment on lines
116
to
118
| return tmpl.format( | ||
| rules_dir=str(rules_dir.resolve()), | ||
| extra_instructions=extra or "(none)", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will enable the agent to change the files locally when running in dry-run mode.